search

open-research / sumatra

http://neuralensemble.org/sumatra/
BSD 2-Clause "Simplified" License
127 stars 48 forks source link

added Python3.5 support #305

Closed timtroendle closed 9 years ago

timtroendle commented 9 years ago

I removed the dateutil dependency from the Travis build as it caused trouble and I couldn't figure out why it was there in the first place. @apdavison, @maxalbert let me know if there is a reason to keep it.

maxalbert commented 9 years ago

Thanks! This looks good to me. I can't comment on your question about dateutil, but hopefully @apdavison knows the answer.

It's interesting that Python 3.5 raises ValueError instead of TypeError in a few places. I'm wondering if it's worth adding a comment to that effect in the code so that in the future it's easier to remember that we can drop the ValueErrors from the except statements. Might not be worth it, though, just a thought.

apdavison commented 9 years ago

I thought dateutil was an indirect dependency, but since everything seems to install fine without it, it's ok to remove it.