search

open-research / sumatra

http://neuralensemble.org/sumatra/
BSD 2-Clause "Simplified" License
127 stars 48 forks source link

Make the NTParameter.save method compatible with NeuroTools' ParameterSet #359

Closed alcrene closed 7 years ago

alcrene commented 7 years ago

NeuroTools' ParameterSet class does not provide an 'add_extension', as the other parameter types defined in Sumatra do. This leads to problems as other functions pass that keyword explicitly. This commit adds a save method to the empty NTParameter class, which catches the call and treats the 'add_extension' keyword, before forwarding the call to the parameter's save method as before.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.05%) to 72.734% when pulling 9519964dc11f1f70b6406efa2c7c81d03c220219 on alcrene:master into 0cd1094cad0d55ade58b96f2bbb6e34781531fcf on open-research:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.05%) to 72.734% when pulling 7b6d81d130b4e0c4f1eb368198866b3b0cbdcb36 on alcrene:master into 0cd1094cad0d55ade58b96f2bbb6e34781531fcf on open-research:master.