search

open-resources / learning_outcomes

MIT License
0 stars 3 forks source link

new LOs for center of gravity #36

Closed sarajamshidn closed 1 year ago

sarajamshidn commented 2 years ago

We need new LOs for centre of gravity. PR: https://github.com/open-resources/instructor_physics_bank/pull/1104

muneebaashiq commented 1 year ago

Learning outcomes were added to the question and to the list of the main list of learning outcomes.

muneebaashiq commented 1 year ago

Hi,

Is it possible for you to send me the link of where you have added this change. Did you do this in a separate branch because I am unable to find it? I believe that we do need to update the csv file but as of right now I do not have the instructions on how to do that. Maybe we can ask about this in the next meeting,

Kind regards, Muneeba

On Sat, Jul 1, 2023 at 3:49 AM Alyssa Kong @.***> wrote:

Hi @muneebaashiq https://github.com/muneebaashiq I've added the code to the question as 10.6.0.0 following the instructions in the readme file, I'm not sure if the csv file should be updated with this code?

— Reply to this email directly, view it on GitHub https://github.com/open-resources/learning_outcomes/issues/36#issuecomment-1615256115, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXIITPQWLANJA4SONXJEX2LXN5JWFANCNFSM6AAAAAAQHJIGXM . You are receiving this because you were mentioned.Message ID: @.***>

naclsodium commented 1 year ago

Hey, Its in the pull request, I changed it to 10.6.1.0 because I realized I forgot to add the subtopic.

On Wed, Jul 5, 2023 at 1:07 PM muneebaashiq @.***> wrote:

Hi,

Is it possible for you to send me the link of where you have added this change. Did you do this in a separate branch because I am unable to find it? I believe that we do need to update the csv file but as of right now I do not have the instructions on how to do that. Maybe we can ask about this in the next meeting,

Kind regards, Muneeba

On Sat, Jul 1, 2023 at 3:49 AM Alyssa Kong @.***> wrote:

Hi @muneebaashiq https://github.com/muneebaashiq I've added the code to the question as 10.6.0.0 following the instructions in the readme file, I'm not sure if the csv file should be updated with this code?

— Reply to this email directly, view it on GitHub < https://github.com/open-resources/learning_outcomes/issues/36#issuecomment-1615256115>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/AXIITPQWLANJA4SONXJEX2LXN5JWFANCNFSM6AAAAAAQHJIGXM>

. You are receiving this because you were mentioned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/open-resources/learning_outcomes/issues/36#issuecomment-1622425325, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZ4ELQRENGGM33MAGYZ3F3DXOXCRDANCNFSM6AAAAAAQHJIGXM . You are receiving this because you commented.Message ID: @.***>

muneebaashiq commented 1 year ago

Hi, Yes I see it I will ask Dr. Moosvi on how we can update the csv file and try to do it. Thank you

firasm commented 1 year ago

fixed in #47