open-rmf / free_fleet

A free fleet management system.
Apache License 2.0
156 stars 65 forks source link

Fix compilation errors for ros2 client on Humble #117

Closed eliasdc closed 1 year ago

eliasdc commented 2 years ago

Fix applied

response callback signature updated to support galactic and humble. I don't believe this builds on Foxy (haven't tested it).

aimethierry commented 1 year ago

You would need to sign your commits with GPG before I can merge it, thanks!

Regarding Foxy support, it should not be too big a concern, if anyone requires it, I can create a foxy branch.

I am using Foxy, however i can compile and run, but the goal is being rejected by the server

aaronchongth commented 1 year ago

Edit @aimethierry Could you provide more information about the rejection? Namely

aimethierry commented 1 year ago

at the moment nothing is happening and i am using Ubuntu 20.04 Ros2 foxy simulation

aaronchongth commented 1 year ago

Could you provide more information for me to try to re-create the issue? What steps have you run, was the goal through nav2 or a free fleet request?

aimethierry commented 1 year ago

Sorry for late reply, these are the steps I followed

  1. Cloned free fleet package
  2. removed all folder remained with free_fleet_client_ros2, free_fleet_server_ros2, and free_fleet
  3. changed line 552 in client_node.cpp to ( send_goal_options.goal_response_callback = [&](std::shared_future future) { auto goal_handle = future.get(); ) so that i can be able to build
  4. build the package (This went well)
  5. run server (ros2 launch ff_examples_ros2 turtlebot3_world_ff_server.launch.xml)
  6. opened new terminal (ros2 launch ff_examples_ros2 turtlebot3_world_ff.launch.xml)
  7. opened new terminal (ros2 run ff_examples_ros2 send_path_request.py -f FLEET_NAME -r ROBOT_NAME -i UNIQUE_TASK_ID -p '[{"x": 1.725, "y": -0.39, "yaw": 0.0, "level_name": "B1"}, {"x": 1.737, "y": 0.951, "yaw": 1.57, "level_name": "B1"}, {"x": -0.616, "y": 1.852, "yaw": 3.14, "level_name": "B1"}, {"x": -0.626, "y": -1.972, "yaw": 4.71, "level_name": "B1"}]')

after doing the above steps i got the following result on the server terminal

aaronchongth commented 1 year ago

Thanks for the information @aimethierry.

For long logs, please use https://gist.github.com, or

code blocks

This has grown out of the scope of this PR, please continue the conversation in https://github.com/open-rmf/free_fleet/issues/113, or try out the fixes mentioned in that thread.