search

open-rmf / rmf

Root repository for the RMF software
Apache License 2.0
238 stars 59 forks source link

Update Dockerfile #114

Closed tongkiat closed 2 years ago

tongkiat commented 2 years ago

Update from foxy to galactic

Update Dockerfile to use ros:galactic instead of ros:foxy.

Yadunund commented 2 years ago

@marcoag should we provide two separate dockerfiles, one for foxy and one for galactic? Or are the changes here okay?

codecov[bot] commented 2 years ago

Codecov Report

Merging #114 (7aa3ea1) into main (6acb517) will decrease coverage by 0.05%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   18.11%   18.05%   -0.06%     
==========================================
  Files         811      812       +1     
  Lines       68717    68681      -36     
  Branches    28482    28502      +20     
==========================================
- Hits        12446    12399      -47     
- Misses      41373    41376       +3     
- Partials    14898    14906       +8
Flag Coverage Δ
tests 18.05% <ø> (-0.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/rmf_fleet_adapter/services/ProgressEvaluator.cpp 40.00% <0.00%> (-9.10%) :arrow_down:
....1.0/Rx/v2/src/rxcpp/operators/rx-subscribe_on.hpp 39.02% <0.00%> (-7.32%) :arrow_down:
...ter/services/detail/impl_FindEmergencyPullover.hpp 47.45% <0.00%> (-6.78%) :arrow_down:
...er/src/rmf_fleet_adapter/phases/ResponsiveWait.cpp 25.92% <0.00%> (-4.94%) :arrow_down:
...adapter/src/rmf_fleet_adapter/phases/MoveRobot.hpp 30.15% <0.00%> (-3.18%) :arrow_down:
...2/rmf_fleet_adapter/test/phases/test_GoToPlace.cpp 25.96% <0.00%> (-1.93%) :arrow_down:
...f_fleet_adapter/jobs/detail/impl_SearchForPath.hpp 19.81% <0.00%> (-1.89%) :arrow_down:
...pp/RxCpp-4.1.0/Rx/v2/src/rxcpp/rx-subscription.hpp 59.14% <0.00%> (-1.83%) :arrow_down:
...RxCpp-4.1.0/Rx/v2/src/rxcpp/operators/rx-merge.hpp 40.00% <0.00%> (-1.82%) :arrow_down:
...f_fleet_adapter/services/detail/impl_Negotiate.hpp 29.66% <0.00%> (-1.70%) :arrow_down:
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6acb517...7aa3ea1. Read the comment docs.

orensbruli commented 2 years ago

Closing it because the modification got out of date.