search

open-rmf / rmf

Root repository for the RMF software
Apache License 2.0
225 stars 58 forks source link

Remove rmf_cmake_uncrustify #115

Closed Yadunund closed 2 years ago

Yadunund commented 2 years ago

We currently have the rmf_cmake_uncrustify package that is used for style checking with colcon test. The original reason for having this package and not using ament_cmake_uncrustify was that the latter did not support custom uncrustify configuration files. But this feature was merged upstream quite a while ago and has been part of foxy and galactic releases. Hence, switching back to ament_cmake_uncrustify for ease of maintenance and distribution.

codecov[bot] commented 2 years ago

Codecov Report

Merging #115 (4e1a9db) into main (6acb517) will increase coverage by 0.22%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   17.84%   18.07%   +0.22%     
==========================================
  Files         812      812              
  Lines       70036    68681    -1355     
  Branches    29375    28502     -873     
==========================================
- Hits        12498    12414      -84     
+ Misses      42513    41358    -1155     
+ Partials    15025    14909     -116
Flag Coverage Δ
tests 18.07% <ø> (+0.23%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....1.0/Rx/v2/src/rxcpp/operators/rx-subscribe_on.hpp 39.02% <0.00%> (-7.32%) :arrow_down:
...2/rmf_fleet_adapter/src/rmf_fleet_adapter/Task.cpp 44.32% <0.00%> (-5.16%) :arrow_down:
...2/rmf_fleet_adapter/test/phases/test_GoToPlace.cpp 25.96% <0.00%> (-3.85%) :arrow_down:
...adapter/src/rmf_fleet_adapter/phases/MoveRobot.hpp 30.15% <0.00%> (-3.18%) :arrow_down:
...er/src/rmf_fleet_adapter/phases/ResponsiveWait.cpp 28.39% <0.00%> (-2.47%) :arrow_down:
...mf_fleet_adapter/test/phases/test_DispenseItem.cpp 31.81% <0.00%> (-2.28%) :arrow_down:
...f_fleet_adapter/jobs/detail/impl_SearchForPath.hpp 19.81% <0.00%> (-1.89%) :arrow_down:
...RxCpp-4.1.0/Rx/v2/src/rxcpp/operators/rx-merge.hpp 40.00% <0.00%> (-1.82%) :arrow_down:
...ter/services/detail/impl_FindEmergencyPullover.hpp 52.54% <0.00%> (-1.70%) :arrow_down:
...f_fleet_adapter/services/detail/impl_Negotiate.hpp 29.66% <0.00%> (-1.70%) :arrow_down:
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6acb517...4e1a9db. Read the comment docs.