search

open-rmf / rmf

Root repository for the RMF software
Apache License 2.0
225 stars 58 forks source link

install instructions: don't pass rosdep the ignore-errors flag #119

Closed codebot closed 2 years ago

codebot commented 2 years ago

In the installation instructions, currently we suggest to use the -r flag during rosdep install, which tells rosdep to ignore errors. Unfortunately due to the amount of console output produced, it's basically impossible to note things like missing rosdep keys or other errors. This PR just removes the -r flag from the installation instructions, which will cause rosdep to halt when it sees an error, so that it's easier to track it down during dependency-installation, rather than at compilation time or run time.

Signed-off-by: Morgan Quigley morgan@osrfoundation.org

codecov[bot] commented 2 years ago

Codecov Report

Merging #119 (ed59d23) into main (ef1858c) will increase coverage by 0.20%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   17.83%   18.03%   +0.20%     
==========================================
  Files         812      812              
  Lines       70143    68734    -1409     
  Branches    29128    28520     -608     
==========================================
- Hits        12507    12394     -113     
+ Misses      42648    41434    -1214     
+ Partials    14988    14906      -82
Flag Coverage Δ
tests 18.03% <ø> (+0.21%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eet_adapter/src/rmf_fleet_adapter/jobs/Rollout.cpp 0.00% <0.00%> (-75.00%) :arrow_down:
...src/rmf_fleet_adapter/jobs/detail/impl_Rollout.hpp 0.00% <0.00%> (-66.67%) :arrow_down:
...raffic/rmf_traffic/src/rmf_traffic/agv/Rollout.cpp 63.63% <0.00%> (-18.19%) :arrow_down:
...f_fleet_adapter/services/detail/impl_Negotiate.hpp 23.72% <0.00%> (-7.63%) :arrow_down:
...f_fleet_adapter/jobs/detail/impl_SearchForPath.hpp 20.18% <0.00%> (-4.63%) :arrow_down:
...adapter/src/rmf_fleet_adapter/phases/MoveRobot.hpp 30.15% <0.00%> (-3.18%) :arrow_down:
...er/src/rmf_fleet_adapter/phases/ResponsiveWait.cpp 28.39% <0.00%> (-2.47%) :arrow_down:
...mf_fleet_adapter/test/phases/test_DispenseItem.cpp 31.81% <0.00%> (-2.28%) :arrow_down:
...er/src/rmf_fleet_adapter/agv/FleetUpdateHandle.cpp 17.97% <0.00%> (-2.09%) :arrow_down:
...s2/rmf_fleet_adapter/test/phases/test_DoorOpen.cpp 33.11% <0.00%> (-1.99%) :arrow_down:
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef1858c...ed59d23. Read the comment docs.