Closed orensbruli closed 1 year ago
rmf_utils
failing with uncrustify
tests (fail 001)rmf_traffic
fail with (fail 002)
fail 001
2: Code style divergence in file 'include/rmf_utils/clone_ptr.hpp':
2:
2: --- include/rmf_utils/clone_ptr.hpp
2: +++ include/rmf_utils/clone_ptr.hpp.uncrustify
2: @@ -42 +42 @@
2: -clone_ptr<T> make_clone(Args&&... args);
2: +clone_ptr<T> make_clone(Args&& ... args);
2: @@ -197 +197 @@
2: -clone_ptr<T> make_clone(Args&&... args)
2: +clone_ptr<T> make_clone(Args&& ... args)
2:
2: Code style divergence in file 'include/rmf_utils/impl_ptr.hpp':
2:
2: --- include/rmf_utils/impl_ptr.hpp
2: +++ include/rmf_utils/impl_ptr.hpp.uncrustify
2: @@ -323 +323 @@
2: -inline unique_impl_ptr<T> make_unique_impl(Args&&... args)
2: +inline unique_impl_ptr<T> make_unique_impl(Args&& ... args)
2: @@ -477 +477 @@
2: -inline impl_ptr<T> make_impl(Args&&... args)
2: +inline impl_ptr<T> make_impl(Args&& ... args)
2: @@ -484 +484 @@
2: -impl_ptr<U> make_derived_impl(Args&&... args)
2: +impl_ptr<U> make_derived_impl(Args&& ... args)
2:
2: 2 files with code style divergence
fail 002
test 1
Start 1: test_rmf_traffic
1: Test command: /usr/bin/python3.10 "-u" "/opt/ros/humble/share/ament_cmake_test/cmake/run_test.py" "/__w/rmf/rmf/ros_ws/build/rmf_traffic/test_results/rmf_traffic/test_rmf_traffic.catch2.xml" "--package-name" "rmf_traffic" "--output-file" "/__w/rmf/rmf/ros_ws/build/rmf_traffic/ament_cmake_catch2/test_rmf_traffic.txt" "--command" "/__w/rmf/rmf/ros_ws/build/rmf_traffic/test_rmf_traffic" "-r junit" "-o /__w/rmf/rmf/ros_ws/build/rmf_traffic/test_results/rmf_traffic/test_rmf_traffic.catch2.xml"
1: Test timeout computed to be: 300
1: -- run_test.py: invoking following command in '/__w/rmf/rmf/ros_ws/build/rmf_traffic':
1: - /__w/rmf/rmf/ros_ws/build/rmf_traffic/test_rmf_traffic -r junit -o /__w/rmf/rmf/ros_ws/build/rmf_traffic/test_results/rmf_traffic/test_rmf_traffic.catch2.xml
1: -- run_test.py: return code 1
1: -- run_test.py: verify result file '/__w/rmf/rmf/ros_ws/build/rmf_traffic/test_results/rmf_traffic/test_rmf_traffic.catch2.xml'
1/1 Test #1: test_rmf_traffic .................***Failed 69.35 sec
0% tests passed, 1 tests failed out of 1
log 001
<testcase classname="test_rmf_traffic.global" name="Scenario: Test planning/When: initial and goal waypoints are same but goal_orientation is different" time="0.001" status="run">
<failure message="err == Approx(0.0)" type="CHECK">
FAILED:
CHECK( err == Approx(0.0) )
with expansion:
5.0 == Approx( 0.0 )
at /__w/rmf/rmf/ros_ws/src/rmf/rmf_traffic/rmf_traffic/test/unit/agv/test_Planner.cpp:1024
</failure>
</testcase>
ERROR: Rosdep experienced an error: Multiple packages found with the same name "rmf_fleet_adapter":
- rmf_core/rmf_fleet_adapter
- rmf_fleet_adapter_python/rmf_fleet_adapter
Multiple packages found with the same name "rmf_task_ros2":
- rmf_core/rmf_task_ros2
- rmf_fleet_adapter_python/rmf_task_ros2
Multiple packages found with the same name "rmf_traffic_ros2":
- rmf_core/rmf_traffic_ros2
- rmf_fleet_adapter_python/rmf_traffic_ros2
Please go to the rosdep page [1] and file a bug report with the stack trace below.
[1] : http://www.ros.org/wiki/rosdep
rosdep version: 0.22.1
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/rosdep2/main.py", line 146, in rosdep_main
exit_code = _rosdep_main(args)
File "/usr/lib/python3/dist-packages/rosdep2/main.py", line 446, in _rosdep_main
return _package_args_handler(command, parser, options, args)
File "/usr/lib/python3/dist-packages/rosdep2/main.py", line 501, in _package_args_handler
pkgs = find_catkin_packages_in(path, options.verbose)
File "/usr/lib/python3/dist-packages/rosdep2/catkin_packages.py", line [35](https://github.com/open-rmf/rmf_ros2/actions/runs/3650836161/jobs/6167327718#step:6:36), in find_catkin_packages_in
packages = find_packages(path)
File "/usr/local/lib/python3.10/dist-packages/catkin_pkg/packages.py", line 103, in find_packages
raise RuntimeError('\n'.join(duplicates))
RuntimeError: Multiple packages found with the same name "rmf_fleet_adapter":
- rmf_core/rmf_fleet_adapter
- rmf_fleet_adapter_python/rmf_fleet_adapter
Multiple packages found with the same name "rmf_task_ros2":
- rmf_core/rmf_task_ros2
- rmf_fleet_adapter_python/rmf_task_ros2
Multiple packages found with the same name "rmf_traffic_ros2":
- rmf_core/rmf_traffic_ros2
- rmf_fleet_adapter_python/rmf_traffic_ros2
asan uncrustify 001
1: Code style divergence in file 'src/rmf_traffic_ros2/schedule/MirrorManager.cpp':
1:
1: --- src/rmf_traffic_ros2/schedule/MirrorManager.cpp
1: +++ src/rmf_traffic_ros2/schedule/MirrorManager.cpp.uncrustify
1: @@ -653 +653 @@
1: - static MirrorManager make(Args&& ... args)
1: + static MirrorManager make(Args&&... args)
1: @@ -878 +878 @@
1: - static MirrorManagerFuture make(Args&& ... args)
1: + static MirrorManagerFuture make(Args&&... args)
1:
1: Code style divergence in file 'src/rmf_traffic_ros2/schedule/Negotiation.cpp':
1:
1: --- src/rmf_traffic_ros2/schedule/Negotiation.cpp
1: +++ src/rmf_traffic_ros2/schedule/Negotiation.cpp.uncrustify
1: @@ -84 +84 @@
1: - Args&& ... args)
1: + Args&&... args)
1:
1: Code style divergence in file 'src/rmf_traffic_ros2/schedule/ParticipantRegistry.cpp':
1:
1: --- src/rmf_traffic_ros2/schedule/ParticipantRegistry.cpp
1: +++ src/rmf_traffic_ros2/schedule/ParticipantRegistry.cpp.uncrustify
1: @@ -45 +45 @@
1: - return std::hash<std::string>{} (id.name + id.owner);
1: + return std::hash<std::string>{}(id.name + id.owner);
1:
1: 3 files with code style divergence
asan uncrustify 002
1: Code style divergence in file 'src/rmf_fleet_adapter/services/ProgressEvaluator.cpp':
1:
1: --- src/rmf_fleet_adapter/services/ProgressEvaluator.cpp
1: +++ src/rmf_fleet_adapter/services/ProgressEvaluator.cpp.uncrustify
1: @@ -45 +45,2 @@
1: - best_estimate = Info{cost, &setup};
1: + best_estimate = Info{cost, &setup}
1: + ;
1: @@ -65 +66,2 @@
1: - best_result = Info{cost, &progress};
1: + best_result = Info{cost, &progress}
1: + ;
1: @@ -69 +71,2 @@
1: - second_best_estimate = Info{cost, &progress};
1: + second_best_estimate = Info{cost, &progress}
1: + ;
1: @@ -129 +132,2 @@
1: - best_discarded = Info{cost, &progress};
1: + best_discarded = Info{cost, &progress}
1: + ;
1:
1: Code style divergence in file 'src/rmf_fleet_adapter/tasks/Clean.cpp':
1:
1: --- src/rmf_fleet_adapter/tasks/Clean.cpp
1: +++ src/rmf_fleet_adapter/tasks/Clean.cpp.uncrustify
1: @@ -293 +293,2 @@
1: - return {nullptr, confirm.errors()};
1: + return {nullptr, confirm.errors()}
1: + ;
1: @@ -313 +314,2 @@
1: - return {nullptr, std::move(clean_task.errors)};
1: + return {nullptr, std::move(clean_task.errors)}
1: + ;
1:
1: Code style divergence in file 'src/rmf_fleet_adapter/tasks/Compose.cpp':
1:
1: --- src/rmf_fleet_adapter/tasks/Compose.cpp
1: +++ src/rmf_fleet_adapter/tasks/Compose.cpp.uncrustify
1: @@ -61 +61,2 @@
1: - return {nullptr, std::move(phase.errors)};
1: + return {nullptr, std::move(phase.errors)}
1: + ;
1: @@ -78 +79,2 @@
1: - return {nullptr, std::move(event.errors)};
1: + return {nullptr, std::move(event.errors)}
1: + ;
1: @@ -106 +108,2 @@
1: - return {nullptr, {"Not accepting composed requests"}};
1: + return {nullptr, {"Not accepting composed requests"}}
1: + ;
1: @@ -125 +128,2 @@
1: - return {nullptr, std::move(phase_activity.errors)};
1: + return {nullptr, std::move(phase_activity.errors)}
1: + ;
1: @@ -145 +149,2 @@
1: - return {nullptr, std::move(cancellation_activity.errors)};
1: + return {nullptr, std::move(cancellation_activity.errors)}
1: + ;
1: @@ -167 +172,2 @@
1: - return {nullptr, confirm.errors()};
1: + return {nullptr, confirm.errors()}
1: + ;
1: @@ -213 +219,2 @@
1: - return {std::nullopt, std::move(errors)};
1: + return {std::nullopt, std::move(errors)}
1: + ;
1: @@ -246 +253,2 @@
1: - return {nullptr, std::move(dependencies.errors)};
1: + return {nullptr, std::move(dependencies.errors)}
1: + ;
1:
1: Code style divergence in file 'src/rmf_fleet_adapter/tasks/Delivery.cpp':
1:
1: --- src/rmf_fleet_adapter/tasks/Delivery.cpp
1: +++ src/rmf_fleet_adapter/tasks/Delivery.cpp.uncrustify
1: @@ -232 +232,2 @@
1: - return {nullptr, {"Not accepting delivery requests"}};
1: + return {nullptr, {"Not accepting delivery requests"}}
1: + ;
1: @@ -275 +276,2 @@
1: - return {nullptr, confirm.errors()};
1: + return {nullptr, confirm.errors()}
1: + ;
1:
1: Code style divergence in file 'src/rmf_fleet_adapter/tasks/Patrol.cpp':
1:
1: --- src/rmf_fleet_adapter/tasks/Patrol.cpp
1: +++ src/rmf_fleet_adapter/tasks/Patrol.cpp.uncrustify
1: @@ -61 +61,2 @@
1: - return {nullptr, std::move(place.errors)};
1: + return {nullptr, std::move(place.errors)}
1: + ;
1: @@ -77 +78,2 @@
1: - return {nullptr, place.errors};
1: + return {nullptr, place.errors}
1: + ;
1: @@ -111 +113,2 @@
1: - return {nullptr, {"Not accepting patrol requests"}};
1: + return {nullptr, {"Not accepting patrol requests"}}
1: + ;
1: @@ -129 +132,2 @@
1: - return {nullptr, std::move(errors)};
1: + return {nullptr, std::move(errors)}
1: + ;
1: @@ -137 +141,2 @@
1: - return {nullptr, errors};
1: + return {nullptr, errors}
1: + ;
1:
1: Code style divergence in file 'test/services/test_Negotiate.cpp':
1:
1: --- test/services/test_Negotiate.cpp
1: +++ test/services/test_Negotiate.cpp.uncrustify
1: @@ -581 +581 @@
1: - static std::shared_ptr<Responder> make(Args&& ... args)
1: + static std::shared_ptr<Responder> make(Args&&... args)
1:
1: 8 files with code style divergence
asan uncrustify 003
1: Code style divergence in file 'rmf_rxcpp/include/rmf_rxcpp/RxJobs.hpp':
1:
1: --- rmf_rxcpp/include/rmf_rxcpp/RxJobs.hpp
1: +++ rmf_rxcpp/include/rmf_rxcpp/RxJobs.hpp.uncrustify
1: @@ -35 +35 @@
1: -inline auto merge_jobs(const Job0& o0, Jobs&& ... os)
1: +inline auto merge_jobs(const Job0& o0, Jobs&&... os)
1:
1: Code style divergence in file 'src/rmf_fleet_adapter/agv/internal_FleetUpdateHandle.hpp':
1:
1: --- src/rmf_fleet_adapter/agv/internal_FleetUpdateHandle.hpp
1: +++ src/rmf_fleet_adapter/agv/internal_FleetUpdateHandle.hpp.uncrustify
1: @@ -329 +329 @@
1: - static std::shared_ptr<FleetUpdateHandle> make(Args&& ... args)
1: + static std::shared_ptr<FleetUpdateHandle> make(Args&&... args)
:100: GREAT DOCUMENTATION ON HOW TO FIX ASAN TSAN ERRORS: https://github.com/colcon/colcon-sanitizer-reports/blob/master/README.rst
Focused on fixing CI and workflows