open-rmf / rmf

Root repository for the RMF software
Apache License 2.0
238 stars 59 forks source link

Fix docker images #480

Open Yadunund opened 3 months ago

Yadunund commented 3 months ago

Before proceeding, is there an existing issue or discussion for this?

Description

The DOCKERFILE on main uses humble as the underlay https://github.com/open-rmf/rmf/blob/1c08ff48216b2f36199bf62e12358edcd2ce0616/Dockerfile#L5

Following recent updates across the codebase to support Gazebo Harmonic and drop support for Gazebo Classic, the scheduled docker job fails since the required gz debs are not available on 22.04.

This leads to #477.

In #479 i've upgraded the underlay to rolling which is what it should be in main. Following that, we could update each distro branch to build with the corresponding underlay and create distro specific tags, ie, update https://github.com/open-rmf/rmf/blob/1c08ff48216b2f36199bf62e12358edcd2ce0616/.github/workflows/build.yaml#L22.

Personally I'm keen on dropping the docker images since this was something we needed before we overhauled our versioning and release process to release binaries more frequently. It seems like quite a hassle to maintain. But open to discussing this further.