open-rmf / rmf_obstacle

Packages that infer the presence of obstacles from sensor inputs.
Apache License 2.0
6 stars 9 forks source link

LifeCycle_Preview created #19

Closed Avisheet closed 4 months ago

Avisheet commented 8 months ago

rmf_obstacle_detector_laserscan waiting to configure

While running ros2 run rmf_obstacle_detector_laserscan laserscan_detector , I encountered waiting to configure . The Lifecycle_preview provides a detailed description about how to configure and activate the node.

WhatsApp Image 2024-03-16 at 4 58 31 PM

Avisheet commented 8 months ago

Thanks @Yadunund for reviewing and giving me suggestions . I was firstly thinking to provide a different markdown page for this with a brief description . I will ensure to make the changes as suggested . Can you tell me should I add the picture of this "waiting to configure..." point or should I just add the commands .

Yadunund commented 8 months ago

No need to include a screenshot.

Yadunund commented 8 months ago

@Avisheet do you still plan on addressing the comments in the PR?

Avisheet commented 8 months ago

Yes @Yadunund . Due to some issues, I wast able to focus here . But I ensure you that I will be working on this .

Avisheet commented 8 months ago

Hey @Yadunund, I have rebased my PR with the main. I request you to review my PR and tell me the desired changes.

Yadunund commented 8 months ago

The first commit still has changes from a different author.

Avisheet commented 8 months ago

Hey @Yadunund, should I also remove commits 5,6 and 7?

Avisheet commented 8 months ago

Hey @Yadunund , the last two commits appeard while resolving the merge errors after removing commits from other authors , can you once review it and tell me the desired changes I need to do now.

Yadunund commented 8 months ago

Please resolve conflicts with main