search

open-rmf / rmf_obstacle

Packages that infer the presence of obstacles from sensor inputs.
Apache License 2.0
6 stars 9 forks source link

Update README.md with lifecylce node info and fix minor typos #28

Open maverick-g00se opened 7 months ago

maverick-g00se commented 7 months ago

Bug fix

Fixed bug

As per the suggestion/request in the comments by @Yadunund from issue: #15

Note: PR #19 does attempt to solve the aforementioned as well. However, that PR has been left idle for over 2 weeks so I thought I might give it a whirl :)

Fix applied

Added extra lifecycle node information to the README.md and fixed some other minor typos accordingly as well.

Yadunund commented 7 months ago

Thanks for the PR. There seems to be some overlap with https://github.com/open-rmf/rmf_obstacle/pull/19 and since that PR was opened first, we should build off that to attribute changes to the author.

maverick-g00se commented 4 months ago

Hey @Yadunund, Hope all is well! It has been about 3 months and PR #19 has stagnated. I'm just wondering since the aforementioned PR has dropped off, if we can move forward with this PR instead. Thanks!

Yadunund commented 4 months ago

@maverick-g00se thanks for the ping. I've merged #19. Could your rebase this PR before we merge it in?

maverick-g00se commented 4 months ago

@Yadunund, I have just resolved the existing conflicts :)

Yadunund commented 4 months ago

Can you ensure your commits are signed so that DCO check passes? https://github.com/open-rmf/rmf_obstacle/pull/28/checks?check_run_id=27898472404