search

open-rmf / rmf_obstacle

Packages that infer the presence of obstacles from sensor inputs.
Apache License 2.0
6 stars 9 forks source link

Hotfix/add missing source value #35

Open MikhailBertrand opened 3 months ago

MikhailBertrand commented 3 months ago

Bug fix

There was an issue in the code where the obstacle information was published within the rmf_human_detector_oakd package. The obstacle.id value was mistakenly inserted twice, leaving the obstacle.source field empty.

As a result, the rmf_visualization_obstacles node ignored the published obstacle, preventing it from being displayed in rviz. https://github.com/open-rmf/rmf_visualization/blob/1130f2cc491736f7dc395abe032d364008c24900/rmf_visualization_obstacles/src/ObstacleVisualizer.cpp#L74-L80

It appears that the detector_name parameter was intended to be used as the source value in the obstacle information being published, so I made the necessary modifications.

Yadunund commented 3 months ago

Thanks for submitting this fix! Will merge after CI passes.