open-rmf / rmf_site

Experimental visualizer for dense buildings in RMF
32 stars 13 forks source link

Fix floor gap on sides of lift that do not have doors #207

Closed mxgrey closed 6 months ago

mxgrey commented 6 months ago

Shortly after #196 was merged I noticed just one more detail about the gap generation that wasn't quite right.

For sides of the cabin that don't have a door, we should just use a minimal gap instead of the cabin's gap parameter. There's no reason to automatically create extra gap around the sides of the lift without any doors. If the user wants fine-grained control of the floor around the lift then they can manually edit the floor accordingly. For automatic hole generation we should stick to only cutting exactly what's needed for the lift to function correctly.

Before: gap_broken

After: gap_fixed

It also seems we accidentally regressed the lockfile with the last PR, so this will fix that as well.