open-rmf / rmf_site

Experimental visualizer for dense buildings in RMF
32 stars 13 forks source link

Fix embedded asset path panic #209

Closed luca-della-vedova closed 5 months ago

luca-della-vedova commented 5 months ago

Bug fix

Fixed bug

Fixes #208.

Fix applied

This is the upstream bug that tracks the reason for our panic https://github.com/bevyengine/bevy/issues/10377. It has been fixed and released in 0.13 but we are on 0.12 as of now. As much as I'm always a big fan of updating we are cannot do it quite yet until bevy_polyline and bevy_infinite_grid are updated, and they seem to always lag about 1 version of bevy.

Luckily there seems to be a workaround in https://github.com/bevyengine/bevy/issues/10377#issuecomment-1858797002 that we can use until we migrate.

To test:

Note that I could only test on Linux, if anyone could test on Windows that would also be great but since this is quite severe I wouldn't necessarily hold that as a blocker.

It should panic without this PR and work fine with it.