open-rmf / rmf_site

Experimental visualizer for dense buildings in RMF
33 stars 13 forks source link

Fix legacy motion_axis_orientation type to f32 #211

Closed luca-della-vedova closed 7 months ago

luca-della-vedova commented 7 months ago

Bug fix

Fixed bug

The type of this legacy field is float not int. Stumbled upon this when importing the legacy roscon_workshop map, i.e. here, the following is returned:

2024-04-04T08:55:03.590297Z ERROR librmf_site_editor::workspace: Failed loading legacy building Message("invalid type: floating point `1.57`, expected i32", Some(Pos { marker: Marker { index: 55291, line: 496, col: 33 }, path: "lifts.lift.doors.door.motion_axis_orientation" }))

Reference in traffic_editor where it is a double

Fix applied

Fix its type, it's actually not used so this shouldn't have any side effects.