open-rmf / rmf_site

Experimental visualizer for dense buildings in RMF
32 stars 13 forks source link

[Bug]: Not able to add the waypoint inside the lift and door of lift #224

Closed VigashiniDotworld closed 2 months ago

VigashiniDotworld commented 3 months ago

Before proceeding, is there an existing issue or discussion for this?

OS and version

Ubuntu 22.04

Open-RMF installation type

Source build

Other Open-RMF installation methods

No response

Open-RMF version or commit hash

2.3.0

ROS distribution

Humble

ROS installation type

Source build

Other ROS installation methods

No response

Package or library, if applicable

No response

Description of the bug

ERROR librmf_site_editor::site::save: Unable to compile site: an object has a reference to an anchor that does not exist

As this error shows when adding the lift waypoint and not able to save the site and generate the nav graph

Steps to reproduce the bug

  1. Add the lift
  2. Add the waypoint inside the lift and to save the anchor point for further nav graph generation.

Expected behavior

No response

Actual behavior

No response

Additional information or screenshots

Screenshot from 2024-06-08 11-28-41

naveenrobo commented 3 months ago

@mxgrey can you please advise on this

luca-della-vedova commented 3 months ago

Can reproduce, looking into it!

naveenrobo commented 3 months ago

@luca-della-vedova I suspect it is because the Anchor is still marked "unsaved". When I try loading the demo hotel building.yaml file it works without any issue. I was able to generate nav_graph. it only happens if we try to create the anchor ourselves in site editor.

luca-della-vedova commented 3 months ago

Yes I believe it is due to it not being assigned a SiteID during site saving

luca-della-vedova commented 3 months ago

Give a try to #226 and see if it works for you

naveenrobo commented 3 months ago

@luca-della-vedova working now. I am able to add lift and waypoints inside and save it as well as generate nav_graphs.

Thanks a lot for the quick fix.

VigashiniDotworld commented 3 months ago

Thanks for immediate response