Fix the production of indefinite charging tasks

open-rmf / rmf_task

RMF library for managing task allocations

Apache License 2.0

22 stars 22 forks source link

Fix the production of indefinite charging tasks #100

Closed mxgrey closed 10 months ago

mxgrey commented 11 months ago

Even though we added the set_indefinite(bool) method to the charge task factory, it wasn't actually being used (whoops).

This PR makes sure that indefinite charging tasks are produced by the factory when the user has requested it.

mxgrey commented 11 months ago

Note that I am not proud of the way that I implemented the fix, but any other approach would have compromised API or ABI stability. I think the current state of the API has accumulated a considerable number of design missteps that can't be fixed without a new major revision, and I'm going to save that for our next generation work.