search

open-rmf / rmf_task

RMF library for managing task allocations
Apache License 2.0
22 stars 19 forks source link

Add find_package/find_dependency for vendored project. #71

Closed nuclearsandwich closed 1 year ago

nuclearsandwich commented 1 year ago

The vendor package for nlohmann_json_schema_validator was previously exporting dependency info for that package, however that is not the recommended workflow for vendor packages which are ideally as transparent as possible.

This PR should be held until https://github.com/open-rmf/nlohmann_json_schema_validator_vendor/pull/10 is merged.

orensbruli commented 1 year ago

@nuclearsandwich it looks like there's some problem with the sign of this commit?

nuclearsandwich commented 1 year ago

@nuclearsandwich it looks like there's some problem with the sign of this commit?

I had to update the branch in order to use the ammended sign

nuclearsandwich commented 1 year ago

@nuclearsandwich it looks like there's some problem with the sign of this commit?

Oh I see, this is not about DCO signing. I have not configured cryptographic signing of Git commits and I'm not going to at this time. I release these changes to be re-applied by maintainers.