search

open-rmf / rmf_task

RMF library for managing task allocations
Apache License 2.0
22 stars 22 forks source link

Add missing buildtool_depend on cmake #75

Closed cottsay closed 1 year ago

cottsay commented 1 year ago

Bug fix

Fixed bug

These packages are missing buildtool dependencies. They're both declared as cmake packages, so they should declare a buildtool dependency on cmake to ensure that package is installed when building.

This missing dependency was discovered when building debs for Rolling packages with -DBUILD_TESTING=OFF and without test dependencies installed. It seems that once of those dependencies is indirectly ensuring that cmake is installed right now.

Fix applied

Add <buildtool_depend>cmake</buildtool_depend> to the package manifests.

cottsay commented 1 year ago

This change should be backported to Humble.

Yadunund commented 1 year ago

Thanks for the fix @cottsay. We've been using main as the development branch so wondering if rolling is meant to serve the same purpose or something else?

cottsay commented 1 year ago

I targeted the branch that is listed in rosdistro: https://github.com/ros/rosdistro/blob/ef2141fa41fdc011b62017ac469dc3b23e6a5a4e/rolling/distribution.yaml#L3937

I didn't intend to do anything crazy here - sorry if that's not the right branch.