search

open-rmf / rmf_traffic

Traffic management libraries for RMF
Apache License 2.0
28 stars 26 forks source link

Using matrix to ease test with different distros #75

Closed marcoag closed 2 years ago

marcoag commented 2 years ago

Signed-off-by: Marco A. Gutierrez marco@openrobotics.org

Bug fix

Fixed bug

Current github workflow tries to add ROS1 repos on jammy and it fails because the Release file it's not there for jammy:

The repository 'http://packages.ros.org/ros/ubuntu jammy Release' does not have a Release file.

Fix applied

Moving github workflow to matrix mode as suggested in https://github.com/ros-tooling/setup-ros/tree/v0.3#iterating-on-all-ros-distributions-for-all-platforms to ease the build and test of different combinations of ubuntu distros and ros distros.

Currently building and testing on focal + galactic and jammy + rolling.

codecov[bot] commented 2 years ago

Codecov Report

Merging #75 (73c390e) into main (822f6b9) will increase coverage by 0.51%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   22.62%   23.14%   +0.51%     
==========================================
  Files         364      370       +6     
  Lines       30020    30589     +569     
  Branches    13836    14269     +433     
==========================================
+ Hits         6792     7079     +287     
- Misses      13940    14078     +138     
- Partials     9288     9432     +144
Flag Coverage Δ
tests 23.00% <ø> (+0.38%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...include/rmf_traffic/agv/CentralizedNegotiation.hpp 66.66% <0.00%> (-33.34%) :arrow_down:
...mf_traffic/include/rmf_traffic/schedule/Change.hpp 50.00% <0.00%> (-16.67%) :arrow_down:
...traffic/src/rmf_traffic/geometry/ShapeInternal.hpp 52.94% <0.00%> (-11.35%) :arrow_down:
..._traffic/src/rmf_traffic/agv/internal_planning.cpp 40.00% <0.00%> (-10.00%) :arrow_down:
rmf_traffic/src/rmf_traffic/StaticMotion.cpp 57.14% <0.00%> (-9.53%) :arrow_down:
...traffic/include/rmf_traffic/agv/RouteValidator.hpp 33.33% <0.00%> (-6.67%) :arrow_down:
rmf_traffic/src/rmf_traffic/agv/Rollout.cpp 57.14% <0.00%> (-6.50%) :arrow_down:
...affic/include/rmf_traffic/schedule/Negotiation.hpp 22.22% <0.00%> (-6.35%) :arrow_down:
rmf_traffic/src/rmf_traffic/schedule/Change.cpp 45.09% <0.00%> (-6.02%) :arrow_down:
...t/agv/planning/test_DifferentialDriveHeuristic.cpp 34.08% <0.00%> (-3.55%) :arrow_down:
... and 120 more