search

open-rmf / rmf_traffic

Traffic management libraries for RMF
Apache License 2.0
28 stars 26 forks source link

Add buildtool_depend keys for CMake. #78

Closed nuclearsandwich closed 2 years ago

nuclearsandwich commented 2 years ago

Bug fix

Fixed bug

When using the cmake build type as these packages cmake needs to be a declared as (at least) a build tool dependency.

rmf_traffic is building because of the transitive cmake dependency brought in by eigen3 via ament_cmake but rmf_traffic_examples is not building in Rolling currently: https://build.ros2.org/job/Rbin_uJ64__rmf_traffic_examples__ubuntu_jammy_amd64__binary/48

Fix applied

Add buildtool_depend keys for cmake.

codecov[bot] commented 2 years ago

Codecov Report

Merging #78 (86310f6) into main (3e54804) will increase coverage by 0.20%. The diff coverage is n/a.

:exclamation: Current head 86310f6 differs from pull request most recent head e312055. Consider uploading reports for the commit e312055 to get more accurate results

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   23.03%   23.23%   +0.20%     
==========================================
  Files         369      370       +1     
  Lines       30761    30741      -20     
  Branches    14366    14362       -4     
==========================================
+ Hits         7086     7143      +57     
+ Misses      14197    14077     -120     
- Partials     9478     9521      +43
Flag Coverage Δ
tests 23.10% <ø> (+0.19%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rmf_traffic/agv/planning/ShortestPathHeuristic.cpp 74.13% <0.00%> (-1.67%) :arrow_down:
rmf_traffic/src/rmf_traffic/agv/Planner.cpp 52.40% <0.00%> (-0.51%) :arrow_down:
rmf_traffic/include/rmf_traffic/Route.hpp 0.00% <0.00%> (ø)
...affic/include/rmf_traffic/schedule/Participant.hpp 0.00% <0.00%> (ø)
...fic/src/rmf_traffic/schedule/internal_Snapshot.hpp 0.00% <0.00%> (ø)
rmf_traffic/test/unit/fcl_test.cpp 37.50% <0.00%> (ø)
rmf_traffic/test/unit/agv/test_Negotiator.cpp 10.87% <0.00%> (+0.03%) :arrow_up:
rmf_traffic/test/unit/agv/test_Planner.cpp 13.64% <0.00%> (+0.04%) :arrow_up:
rmf_traffic/test/unit/schedule/test_Mirror.cpp 14.41% <0.00%> (+0.35%) :arrow_up:
rmf_traffic/src/rmf_traffic/schedule/Mirror.cpp 42.16% <0.00%> (+0.36%) :arrow_up:
... and 9 more
mxgrey commented 2 years ago

Closing this as redundant with #77