search

open-rmf / rmf_traffic

Traffic management libraries for RMF
Apache License 2.0
28 stars 26 forks source link

Loosen numerical precision expectations for time interpolation #81

Closed mxgrey closed 2 years ago

mxgrey commented 2 years ago

Some real-world cases have demonstrated that the time interpolation calculation is expecting too much precision in its floating point calculations. This PR loosens that to reduce (hopefully eliminate) the risk of numerical precision edge cases.

codecov[bot] commented 2 years ago

Codecov Report

Merging #81 (5b9ab37) into main (439eba0) will increase coverage by 0.01%. The diff coverage is 58.82%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   23.14%   23.16%   +0.01%     
==========================================
  Files         370      370              
  Lines       30583    30597      +14     
  Branches    14262    14265       +3     
==========================================
+ Hits         7079     7088       +9     
- Misses      14103    14106       +3     
- Partials     9401     9403       +2
Flag Coverage Δ
tests 23.03% <58.82%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rmf_traffic/src/rmf_traffic/agv/Interpolate.cpp 50.29% <58.82%> (+1.26%) :arrow_up: