search

open-s4c / benchkit

A push-button end-to-end performance evaluation pipeline for automatically exploring the parameter space
MIT License
12 stars 17 forks source link

Implementation for docker background subprocess #106

Closed svendgln closed 2 months ago

svendgln commented 2 months ago

Needed for running commands from CommandAttachments

apaolillo commented 2 months ago

This is a solution that's a bit dangerous, as the user would commonly expect the background process to run inside the docker container. We should keep this use case in mind when revamping the shell commands @aaronbog , and perhaps refactor this code again. Adding a TODO & a WARNING.