search

open-s4c / benchkit

A push-button end-to-end performance evaluation pipeline for automatically exploring the parameter space
MIT License
12 stars 17 forks source link

Adding a post_run_hook to TraceCmd #96

Closed matsvanmolle closed 3 months ago

matsvanmolle commented 3 months ago

Adding a post_run_hook to TraceCmd.

This post_run_hook can be used to do processing of the data generated by trace-cmd.

matsvanmolle commented 3 months ago

I'm currently encountering a bug. The generate-graph.out file is empty. I'm certain that the hook runs, when I provide it with a non-existing .dat file I get output in the .err file telling me the file does not exist.

apaolillo commented 3 months ago

@matsvanmolle if you think it is now ready, you can remove the "draft" status from the PR

matsvanmolle commented 3 months ago

@matsvanmolle if you think it is now ready, you can remove the "draft" status from the PR

@apaolillo Should the graph drawer also be included in the post_run_hook?

apaolillo commented 3 months ago

@apaolillo Should the graph drawer also be included in the post_run_hook?

@matsvanmolle You can if it is ready but we can also merge piece by piece as this PR is quite self-contained.