search

open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
414 stars 220 forks source link

Refactor: tailwind anti-pattern #2053

Open a0m0rajab opened 10 months ago

a0m0rajab commented 10 months ago

Type of feature

🍕 Feature

Current behavior

Right now we have a lot of anit-pattern logic in the app, which it would be great to remove it.

This is related to this issue: https://github.com/open-sauced/app/issues/1522

Suggested solution

Go to the files that we have anti-pattern in them and remove it.

Here is a list of the files that we have: 142 results - 68 files

  1. [ ] components\atoms\Checkbox\checkbox.tsx:
  2. [ ] components\atoms\Cmd\command.tsx:
  3. [ ] components\atoms\Dropdown\dropdown.tsx:
  4. [ ] components\atoms\FilterChip\filter-chip.tsx:
  5. [ ] components\atoms\IconButton\icon-button.tsx:
  6. [ ] components\atoms\LayoutToggle\layout-toggle.tsx:
  7. [ ] components\atoms\PillSelector\pill-selector.tsx:
  8. [ ] components\atoms\ProgressPie\progress-pie.tsx:
  9. [ ] components\atoms\ScrollArea\scroll-area.tsx:
  10. [ ] components\atoms\Select\select.tsx:
  11. [ ] components\atoms\Select\single-select.tsx:
  12. [ ] components\atoms\Tabs\tabs.tsx:
  13. [ ] components\atoms\Toast\toast.tsx:
  14. [ ] components\atoms\ToggleSwitch\toggle-switch.tsx:
  15. [ ] components\ListHeader\list-header.tsx:
  16. [ ] components\molecules\AuthSection\auth-section.tsx:
  17. [ ] components\molecules\CardHorizontalBarChart\card-horizontal-bar-chart.tsx:
  18. [ ] components\molecules\CardRepoList\card-repo-list.tsx:
  19. [ ] components\molecules\ContributorHighlight\contributor-highlight-card.tsx:
  20. [ ] components\molecules\ContributorHoverCard\contributor-hover-card.tsx:
  21. [ ] components\molecules\ContributorListTableHeader\contributor-list-table-header.tsx:
  22. [ ] components\molecules\ContributorListTableRow\contributor-list-table-row.tsx:
  23. [ ] components\molecules\ContributorProfileHeader\contributor-profile-header.tsx:
  24. [ ] components\molecules\DashboardScatterChart\dashboard-scatter-chart.tsx:
  25. [ ] components\molecules\DevCard\dev-card.tsx:
  26. [ ] components\molecules\Dialog\dialog.tsx:
  27. [ ] components\molecules\FavoriteRepoCard\favorite-repo-card.tsx:
  28. [ ] components\molecules\FilterHeader\filter-header.tsx:
  29. [ ] components\molecules\HighlightInput\highlight-input-form.tsx:
  30. [ ] components\molecules\HighlightsFeedCard\highlights-filter-card.tsx:
  31. [ ] components\molecules\HubContributorsHeader\hub-contributors-header.tsx:
  32. [ ] components\molecules\InsightHeader\insight-header.tsx:
  33. [ ] components\molecules\InsightPageCard\insight-page-card.tsx:
  34. [ ] components\molecules\InsightPageTable\insight-page-table.tsx:
  35. [ ] components\molecules\InsightRow\insight-row.tsx:
  36. [ ] components\molecules\InsightTableRow\insight-table-row.tsx:
  37. [ ] components\molecules\NivoScatterChart\nivo-scatter-chart.tsx:
  38. [ ] components\molecules\Pagination\pagination.tsx:
  39. [ ] components\molecules\PieChart\pie-chart.tsx:
  40. [ ] components\molecules\Popover\popover.tsx:
  41. [ ] components\molecules\RepoCardProfile\repo-card-profile.tsx:
  42. [ ] components\molecules\RepoRow\repo-row.tsx:
  43. [ ] components\molecules\ReportsHistory\reports-history.tsx:
  44. [ ] components\molecules\ReposoitoryCartItem\repository-cart-item.tsx:
  45. [ ] components\molecules\SearchResults\search-results.tsx:
  46. [ ] components\molecules\SelectReportsFilter\select-reports-filter.tsx:
  47. [ ] components\molecules\TableHeader\table-header.tsx:
  48. [ ] components\molecules\TableRepositoryName\table-repository-name.tsx:
  49. [ ] components\molecules\WaitlistButton\waitlist-button.tsx:
  50. [ ] components\organisms\ContributorProfileTab\contributor-profile-tab.tsx:
  51. [ ] components\organisms\Contributors\contributors.tsx:
  52. [ ] components\organisms\FollowersHighlightWrapper\following-highlight-wrapper.tsx:
  53. [ ] components\organisms\Footer\footer.tsx:
  54. [ ] components\organisms\HomeHighlightsWrapper\home-highlights-wrapper.tsx:
  55. [ ] components\organisms\InsightPage\DeleteInsightPageModal.tsx:
  56. [ ] components\organisms\Reports\reports.tsx:
  57. [ ] components\organisms\RepositoriesTable\repositories-table.tsx:
  58. [ ] components\organisms\SearchDialog\search-dialog.tsx:
  59. [ ] components\organisms\TopNav\top-nav.tsx:
  60. [ ] components\organisms\UserRepositoryRecommendations\user-repository-recommendations.tsx:
  61. [ ] layouts\filter.tsx:
  62. [ ] layouts\hub-page.tsx:
  63. [ ] layouts\lists.tsx:
  64. [ ] pages\start.tsx:
  65. [ ] pages\feed\index.tsx:
  66. [ ] pages\hub\lists\find.tsx:
  67. [ ] pages\hub\lists\index.tsx:
  68. [ ] pages\user\notifications.tsx:

Note:

If you are an external contributor and contributing to this, I would suggest opening a new issue for each file and doing them in small iterations. To find the anti-pattern you can use this regex ^.*?-\[[^\d]*(\d+)[^\d]*\].*$

@nickytonline: For this work, we'll definitely need before and after screenshots for desktop and mobile views, for each issue created from the items in the task list.

Additional context

No response

Code of Conduct

Contributing Docs

github-actions[bot] commented 10 months ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please reach out to us on Discord or follow up on the issue itself.

For full info on how to contribute, please check out our contributors guide.

nickytonline commented 10 months ago

For this work, we'll definitely need before and after screenshots for desktop and mobile views, for each issue created from the items in the task list.

5hraddha commented 10 months ago

Hi @a0m0rajab / @nickytonline, Would you mind, if I take one of the files listed above, to remove the anti pattern? I'll create a separate issue and would work it. Thanks!

a0m0rajab commented 10 months ago

@5hraddha Sure, just open a new issue and mention this one in it! Looking forward to see your contribution 😄