feat: add workspace layout to user page

open-sauced / app

🍕 Insights into your entire open source ecosystem.

https://pizza.new

Apache License 2.0

381 stars 202 forks source link

feat: add workspace layout to user page #3537

Closed zeucapua closed 2 weeks ago

zeucapua commented 4 weeks ago

Description

Implement WorkspaceLayout component and wrap it on the existing user page

Related Tickets & Documents

Closes #3520 Closes #2780 Closes #3524

Mobile & Desktop Screenshots/Recordings

https://github.com/open-sauced/app/assets/20603494/80180914-4e60-4c05-87ec-074061b84a98

Steps to QA

Tier (staff will fill in)

[ ] Tier 1
[ ] Tier 2
[ ] Tier 3
[x] Tier 4

[optional] What gif best describes this PR or how it makes you feel?

case-closed-legal-gif

netlify[bot] commented 4 weeks ago

Deploy Preview for design-insights ready!

Name	Link
Latest commit	a5578b0b0a7471192853280cdc120bb2271d555e
Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/667073bfaf07d10008bc2f42
Deploy Preview	https://deploy-preview-3537--design-insights.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 weeks ago

Deploy Preview for oss-insights ready!

Name	Link
Latest commit	a5578b0b0a7471192853280cdc120bb2271d555e
Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/667073bfcd6e550009d73eff
Deploy Preview	https://deploy-preview-3537--oss-insights.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bdougie commented 4 weeks ago

What's with the space in the layout?

Screenshot 2024-06-07 at 11 35 32 AM

zeucapua commented 3 weeks ago

Fixed! This will also close #3524! This required removing padding and margins from the WorkspaceLayout, causing layout shifts to every other page already using it. So if you see changes to other pages, that's me adding the padding back to avoid errors (see workspace home below).

cc. @bdougie @nickytonline

nickytonline commented 3 weeks ago

Padding now seems broken on the workspaces page?

Deploy preview:

Beta:

Just like we have a footer slot in the workspaces layout, maybe a header slot will help with the spacing issues while still preserving the layout of pages already using the workspaces layout.

https://github.com/open-sauced/app/blob/8eb580dd723f81ef169af26830e74f2ed2a1fa42/components/Workspaces/WorkspaceLayout.tsx#L84-L88