open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
381 stars 202 forks source link

feat: add contributions filter to contributor profile #3556

Closed brandonroberts closed 2 weeks ago

brandonroberts commented 2 weeks ago

Description

Related Tickets & Documents

Closes #3549

Mobile & Desktop Screenshots/Recordings

image

https://opensauced.rewatch.com/video/v1iko1l6kyco79o0-demo-contributor-profile-issue-comments

Steps to QA

  1. Go to deploy preview
  2. Go to a contributor profile
  3. Click on Contributions and select Issue Comments
  4. See the issue comments table below
  5. Change the range of days to see more if less than 15 are shown

Tier (staff will fill in)

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 2 weeks ago

Deploy Preview for oss-insights ready!

Name Link
Latest commit 8b81f89a74c28fbeccf8ca3e6102f3f31c8bb95e
Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6671b5a022ff6e000803532b
Deploy Preview https://deploy-preview-3556--oss-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for design-insights ready!

Name Link
Latest commit 8b81f89a74c28fbeccf8ca3e6102f3f31c8bb95e
Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6671b5a0cd8f440008738ab1
Deploy Preview https://deploy-preview-3556--design-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

brandonroberts commented 2 weeks ago

@nickytonline 🤝

isabensusan commented 2 weeks ago

Thank you for this!! Some UI comments:

  1. Instead of using the multiselect toggle (it hides other contribution options behind the dropdown), can we use this tab component? image

Like so:

image
  1. Can we replace the "Loading" text with the skeleton animation? image

Kind of like this -- give it a min height of aprox 400px as well so that when it populates, the layout shift isn't as harrowing

image
  1. Give it an empty state: image

image

Empty state image: image

bdougie commented 2 weeks ago

I now see no comments for JiaT75. I previously saw some.

Screenshot 2024-06-14 at 7 25 35 PM
brandonroberts commented 2 weeks ago

The data is still in the API. Could be a caching issue

https://beta.api.opensauced.pizza/v2/users/jiat75/issue-comments?limit=15&range=360

jpmcb commented 2 weeks ago

I now see no comments for JiaT75. I previously saw some.

@bdougie / @brandonroberts - here's a fix for the case-insensitivity for usernames like JiaT75 (which should get lowercased down to jiat75)

https://github.com/open-sauced/api/pull/882

nickytonline commented 2 weeks ago

Seems the whole table breaks out of the div to the right and words get cut off:

Screenshot 2024-06-17 at 4 15 34 PM

I can take a peek at this in the AM if you want @brandonroberts

brandonroberts commented 2 weeks ago

@nickytonline @jpmcb the issue comments table is responsive now

https://github.com/open-sauced/app/assets/42211/53bf5363-e266-4625-a44b-b4b33c737566