Closed brandonroberts closed 2 weeks ago
Name | Link |
---|---|
Latest commit | 8b81f89a74c28fbeccf8ca3e6102f3f31c8bb95e |
Latest deploy log | https://app.netlify.com/sites/oss-insights/deploys/6671b5a022ff6e000803532b |
Deploy Preview | https://deploy-preview-3556--oss-insights.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 8b81f89a74c28fbeccf8ca3e6102f3f31c8bb95e |
Latest deploy log | https://app.netlify.com/sites/design-insights/deploys/6671b5a0cd8f440008738ab1 |
Deploy Preview | https://deploy-preview-3556--design-insights.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@nickytonline 🤝
Thank you for this!! Some UI comments:
Like so:
Kind of like this -- give it a min height of aprox 400px as well so that when it populates, the layout shift isn't as harrowing
Empty state image:
I now see no comments for JiaT75. I previously saw some.
The data is still in the API. Could be a caching issue
https://beta.api.opensauced.pizza/v2/users/jiat75/issue-comments?limit=15&range=360
I now see no comments for JiaT75. I previously saw some.
@bdougie / @brandonroberts - here's a fix for the case-insensitivity for usernames like JiaT75
(which should get lowercased down to jiat75
)
Seems the whole table breaks out of the div to the right and words get cut off:
I can take a peek at this in the AM if you want @brandonroberts
@nickytonline @jpmcb the issue comments table is responsive now
https://github.com/open-sauced/app/assets/42211/53bf5363-e266-4625-a44b-b4b33c737566
Description
JiaT75
in the recent xz vulnerability researchRelated Tickets & Documents
Closes #3549
Mobile & Desktop Screenshots/Recordings
https://opensauced.rewatch.com/video/v1iko1l6kyco79o0-demo-contributor-profile-issue-comments
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?