open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
381 stars 202 forks source link

fix: Contributor Confidence styling #3572

Closed zeucapua closed 2 weeks ago

zeucapua commented 2 weeks ago

Description

Various styling fixes and changes to the ContributorConfidenceChart component

Related Tickets & Documents

Closes #3564 Closes #3558 Closes #3571

Mobile & Desktop Screenshots/Recordings

Various sizes (large, medium, small screens respectively) image image image

Steps to QA

  1. Go to any repo page

  2. Check the Contributor Confidence chart in various screen sizes

netlify[bot] commented 2 weeks ago

Deploy Preview for oss-insights ready!

Name Link
Latest commit a57b4444ef8450807db921f53195167d04769948
Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/6670a3e8a6c7440008088b38
Deploy Preview https://deploy-preview-3572--oss-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for design-insights ready!

Name Link
Latest commit a57b4444ef8450807db921f53195167d04769948
Latest deploy log https://app.netlify.com/sites/design-insights/deploys/6670a3e8bfd0b40008ac0068
Deploy Preview https://deploy-preview-3572--design-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nickytonline commented 2 weeks ago

This renders well, but given it's a half circle, I think we'd need to have the percentages visually halved (not the percentage text).

CleanShot 2024-06-17 at 16 23 04

bdougie commented 2 weeks ago

I think we'd need to have the percentages visually halved

I think I understand but I don't @nickytonline. Can you clarify?

nickytonline commented 2 weeks ago

I think we'd need to have the percentages visually halved

I think I understand I don't @nickytonline. Can you clarify?

For example, looking at 40% in this screenshot, it looks like it's 80% of the half gauge instead of 40%

CleanShot 2024-06-17 at 16 39 30

But again this is just for the bar. The number should still stay at 40%.

zeucapua commented 2 weeks ago

I thought we decided this in the original contributor confidence PR, see @jpmcb's comment here: https://github.com/open-sauced/app/pull/3545#discussion_r1633987143

jpmcb commented 2 weeks ago

looking at 40% in this screenshot, it looks like it's 80% of the half gauge instead of 40%

This is an explicit design decision we made: i.e., 40% is about as high as you'd ever see. Just like with a speed gauge, or a RPM gauge on an engine, the "sweet" range is really only like 30-50% of the actual range of the gauge. You'd never want your RPM gauge on an engine to go all the way to 100%, that would be a problem.

40% in this context is "green" and would be a desired range.

nickytonline commented 2 weeks ago

looking at 40% in this screenshot, it looks like it's 80% of the half gauge instead of 40%

This is an explicit design decision we made: i.e., 40% is about as high as you'd ever see. Just like with a speed gauge, or a RPM gauge on an engine, the "sweet" range is really only like 30-50% of the actual range of the gauge. You'd never want your RPM gauge on an engine to go all the way to 100%, that would be a problem.

40% in this context is "green" and would be a desired range.

OK, all good. Didn't realize that was decided @zeucapua and @jpmcb. I'll go ahead and approve.

bdougie commented 2 weeks ago

I am on BART and missed a lot of this conversation.

What is missing in this context is "40% of the people who engage with the repo make contributions."

That is what confidence identifies and this will make more sense when we ship more of the story. But for now let's ship to learn.