open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
381 stars 202 forks source link

fix: reset input after deleting contributor insight list #3600

Closed shubhamchasing closed 3 days ago

shubhamchasing commented 1 week ago

Description

Now the input is being reset when a contributor insight list is deleted before it was keeping the latest deleted contributor insight list name

Related Tickets & Documents

Fixes #3553

Mobile & Desktop Screenshots/Recordings

Before

https://github.com/open-sauced/app/assets/106425076/71e4628f-247d-4879-bf77-4b690f634e69

After

https://github.com/open-sauced/app/assets/106425076/bf5c103e-fa8a-4a28-9213-aa581a9ec162

Steps to QA

  1. Go to your workspaces
  2. delete one of the list
  3. try deleting another
  4. notice now input is empty

Tier (staff will fill in)

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 1 week ago

Deploy Preview for oss-insights ready!

Name Link
Latest commit 2ac7a3917e5a8a97501a059034c68fd8ed781ad3
Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/667fc48b5e0b3000089f38fd
Deploy Preview https://deploy-preview-3600--oss-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for design-insights ready!

Name Link
Latest commit 2ac7a3917e5a8a97501a059034c68fd8ed781ad3
Latest deploy log https://app.netlify.com/sites/design-insights/deploys/667fc48b38fb8800084ad235
Deploy Preview https://deploy-preview-3600--design-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

shubhamchasing commented 1 week ago

@nickytonline please review

nickytonline commented 6 days ago

The E2E tests failed, but it looks like it was due to the beta API maybe being slow temporarily. I ran it locally and all good. Just restarted the E2E tests on the PR.

CleanShot 2024-06-26 at 10 16 18

shubhamchasing commented 4 days ago

@nickytonline in which release is this PR going to be merged?