Bug: the share button does not close when clicked outside it

open-sauced / app

🍕 Insights into your entire open source ecosystem.

https://pizza.new

Apache License 2.0

412 stars 221 forks source link

Bug: the share button does not close when clicked outside it #3616

Closed a0m0rajab closed 2 months ago

a0m0rajab commented 3 months ago

Describe the bug

Clicking outside the share chat does not close the dialog

https://github.com/open-sauced/app/assets/18273833/fbf610eb-288d-4c10-90a1-4a31cd6a8d74

Steps to reproduce

go to star search
click on the share button
try to click outside it, it would not close

github-actions[bot] commented 3 months ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

a0m0rajab commented 3 months ago

A refactor to the share chat menu to use radix-ui suggestion would work for this:

Here is the code: https://github.com/open-sauced/app/blob/50c5d1111775d3aafd989fb48478dac304b553a0/components/StarSearch/ShareChatMenu.tsx#L37-L42

Here is an example on how it works: https://www.radix-ui.com/primitives/docs/components/dropdown-menu

This could be a good first issue.