Bug: StarSearch for Workspaces prevents page scrolling

nickytonline commented 1 week ago

When using StarSearch for workspaces on a larger screen, StarSearch works as expected, but you are unable to scroll the page if the content overflows the viewport.

This is because when StarSearch the page was built, we wanted to prevent page scrolling and have the chat area be the only scrollable region on the page.

body:has(.star-search) {
  overflow: hidden;
}

See https://github.com/open-sauced/app/blob/beta/styles/globals.css#L290-L292

The fix is to add a :not() with some sort of criteria to indicate that StarSearch is embedded, e.g.

body:has(.star-search:not([data-is-embedded="true"])) {
  overflow: hidden;
}

so that it prevents scrolling of the <body /> on the StarSearch page but not when it's embedded.

Related Slack Conversation

github-actions[bot] commented 1 week ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

jpmcb commented 6 days ago

Duplicate of: https://github.com/open-sauced/app/issues/3609 - #3619 will also close!

open-sauced[bot] commented 6 days ago

:tada: This issue has been resolved in version 2.39.0-beta.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

open-sauced[bot] commented 4 days ago

:tada: This issue has been resolved in version 2.39.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

open-sauced / app

Bug: StarSearch for Workspaces prevents page scrolling #3618