open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
412 stars 221 forks source link

fix: now a new StarSearch chat can be started if one was in progress #3637

Closed nickytonline closed 3 months ago

nickytonline commented 3 months ago

Description

Now isRunning is reset to false when starting a new conversation. This was preventing the stream conversation from beginning when a previous one was cancelled and a new conversation started.

Related Tickets & Documents

Fixes #3636

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-06-25 at 21 25 35

After

CleanShot 2024-06-25 at 21 26 04

Steps to QA

  1. Go to any workspace and open StarSearch
  2. Start a conversation
  3. Cancel it by clicking the back button or new conversation buttons in the compact StarSearch header.
  4. Start the new conversation.
  5. Notice the new conversation streams in.

Tier (staff will fill in)

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 3 months ago

Deploy Preview for design-insights ready!

Name Link
Latest commit 0d0a68845172ec92d2566b6bd1f6fdec2a02d6b0
Latest deploy log https://app.netlify.com/sites/design-insights/deploys/667c28e3f0860e000882fdba
Deploy Preview https://deploy-preview-3637--design-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for oss-insights ready!

Name Link
Latest commit 0d0a68845172ec92d2566b6bd1f6fdec2a02d6b0
Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/667c28e3f1e9290008f8797d
Deploy Preview https://deploy-preview-3637--oss-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

BekahHW commented 3 months ago

@nickytonline when I run this and select a prompt, if it's already mid-response and I hit the back button and select a different prompt, it finishes the first answer before going to the second question. Is that intended?

nickytonline commented 3 months ago

@nickytonline when I run this and select a prompt, if it's already mid-response and I hit the back button and select a different prompt, it finishes the first answer before going to the second question. Is that intended?

Not intended. I'll take a peek at that.

nickytonline commented 3 months ago

@nickytonline when I run this and select a prompt, if it's already mid-response and I hit the back button and select a different prompt, it finishes the first answer before going to the second question. Is that intended?

Not intended. I'll take a peek at that.

Fixed in 0d0a68845172ec92d2566b6bd1f6fdec2a02d6b0