Bug: TypeError: Cannot read properties of undefined (reading 'split') after signing up to OpenSauced

open-sauced / app

🍕 Insights into your entire open source ecosystem.

https://pizza.new

Apache License 2.0

381 stars 202 forks source link

Bug: TypeError: Cannot read properties of undefined (reading 'split') after signing up to OpenSauced #3649

Open nickytonline opened 3 days ago

nickytonline commented 3 days ago

A user reported after signup a client-side crash.

It looks like a string is undefined somewhere. Looking at our codebase, it could be either trying to split a GitHub user's interests or it's a repo that is undefined trying to be split on /. I'm leaning more towards the GitHub interests being the issue without knowing exactly where this happened, but it is post signup.

github-actions[bot] commented 3 days ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

jpmcb commented 3 days ago

Mentioning this here as well:

Interests can definitely be EMPTY in the database which should get surfaced in the v2/users/{username} endpoint as "interests": "". So, this shouldn't be undefined.

Two questions:

Can we replicate this reliably with new test users?
Surprised this wasn't caught by Sentry since it throws in the client. Worth investigating why that might have been.

nickytonline commented 3 days ago

As @jpmcb mentioned, odd that this wasn't caught by Sentry. We'lll need to see if this can be reproduced.