search

open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
414 stars 222 forks source link

Bug: Type error in feed/index.tsx #3696

Closed DhairyaMajmudar closed 2 months ago

DhairyaMajmudar commented 3 months ago

Describe the bug

There's a type error noticed in feed/index.tsx file

Screenshot

image

Steps to reproduce

  1. Navigate to feed/index.tsx file
  2. View the type error in VS code problems tab
github-actions[bot] commented 2 months ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

DhairyaMajmudar commented 2 months ago

This bug can be fixed if we add type boolean with open variable:

onOpenChange={(open: boolean) => {

nickytonline commented 2 months ago

Hi @DhairyaMajmudar. I have the latest of our beta branch, and the open parameter is inferred correctly as a boolean and things build fine.

CleanShot 2024-07-08 at 21 14 36

I'm going to go ahead and close this as there is no issue.

DhairyaMajmudar commented 2 months ago

Hi @DhairyaMajmudar. I have the latest of our beta branch, and the open parameter is inferred correctly as a boolean and things build fine.

CleanShot 2024-07-08 at 21 14 36

I'm going to go ahead and close this as there is no issue.

Seems like issue is resolved in the recent commits.