open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
426 stars 226 forks source link

Bug: Newsletter sign up no longer collects a user's email #3796

Closed nickytonline closed 3 months ago

nickytonline commented 3 months ago

While investigating a build error @netlify/plugin-nextjs@5 requires migration steps to support Netlify Forms. Refer to https://ntl.fyi/next-runtime-forms-migration for migration example. I discovered that our newsletter signup no longer collects emails.

The last one collected appears to have been in March, but a couple tests I did does not collect the emails.

We're using the pages router, but it appears we may need to do the same fix as suggested in the Netlify docs to be able to use Netlify Forms with Next.js. Not sure when this broke.

The fix is detailed at https://docs.netlify.com/frameworks/next-js/overview/#breaking-changes.

github-actions[bot] commented 3 months ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

BekahHW commented 3 months ago

@jpmcb here's the signup link: https://news.opensauced.pizza/#/portal/signup

jpmcb commented 3 months ago

Re-opening since we'll want to tackle the bigger lift of getting the form for newsletter signups to work and re-factor out my quickfix:

https://github.com/open-sauced/app/blob/b550a8c79ceb64e1b7c1c3e4c8a2ee483539c4ff/components/molecules/NewsletterForm/newsletter-form.tsx#L10-L18

nickytonline commented 3 months ago

Once that is complete, we'll want to tackle #3799

open-sauced[bot] commented 3 months ago

:tada: This issue has been resolved in version 2.55.0-beta.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

open-sauced[bot] commented 3 months ago

:tada: This issue has been resolved in version 2.55.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: