open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
426 stars 226 forks source link

Bug: Unexpected drawer behavior #3797

Open ryandotfurrer opened 3 months ago

ryandotfurrer commented 3 months ago

Describe the bug

I'd expect the drawer that you open to access home, repo insights, contributor insights, etc. to close upon clicking a link, however, it stays open.

If this is the intentional behavior, please close this out.

Steps to reproduce

  1. Go to your workspace.
  2. Click the button to open the drawer.
  3. Click a link in there.
github-actions[bot] commented 3 months ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

nickytonline commented 3 months ago

Hey @ryandotfurrer! Thanks for reporting the issue. The side panel closes when you click outside of it, but elements within it currently do not cause it to close aside from the Support menu because the element is outside of the panel.

CleanShot 2024-07-31 at 09 43 13

We could close it when items get clicked within the side panel, but we'd need to add logic to ensure the drop down to select a workspace when clicked doesn't close the side panel. Same for the Support panel.

I'm not sure if adding that additional logic is worth it considering the panel closes as soon as you click outside of it, but if you have some suggestions, feel free to comment with them.

ryandotfurrer commented 3 months ago

@nickytonline I absolutely see where you're coming from. Maybe other users don't expect a drawer to close upon clicking a link inside of it, thus why I didn't see another issue open for this. I agree it's a lot to add without real ROI; just food for thought!