open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
430 stars 230 forks source link

fix: correct width issue caused by tooltip addition in SingleSelect #4058

Closed mouad-dadda closed 3 months ago

mouad-dadda commented 3 months ago

Description

a layout issue in the AppSideBar component caused by a recent change to the SingleSelect component. Specifically, when a tooltip for long titles was added to SingleSelect, a width was set that inadvertently disrupted the layout.

Related Tickets & Documents

Fixes #4031

Mobile & Desktop Screenshots/Recordings

Problem :

Screenshot_25-8-2024_131842_app opensauced pizza

layout issiu

fixed 💯 : fixedall

Steps to QA

Tier (staff will fill in)

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 3 months ago

Deploy Preview for oss-insights ready!

Name Link
Latest commit f1d0b061bcc4c3674065f30e56f2f4fec252f5e7
Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66cf7aa13d49f80008a285a7
Deploy Preview https://deploy-preview-4058--oss-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for design-insights ready!

Name Link
Latest commit f1d0b061bcc4c3674065f30e56f2f4fec252f5e7
Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66cf7aa177517300088d60d1
Deploy Preview https://deploy-preview-4058--design-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nickytonline commented 3 months ago

One other thing to notw @mouad-dadda is that the plus icon is too dark. It should be the same colour as the top level sidebar menu items.

mouad-dadda commented 3 months ago

Got it, @nickytonline :

image

jpmcb commented 3 months ago

Approved netlify run, approved GitHub actions, requested engineering review.