search

open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
429 stars 228 forks source link

Chore: extend "expect" timeouts in Playwright to 10,000ms #4072

Closed jpmcb closed 2 months ago

jpmcb commented 2 months ago

Suggested solution

In an effort to make CI/CD and our dev experience better, we should consider extending the playwright "assertions" timeout:

await expect(locator).toBeHidden({ timeout: 10000 });

This is different from the global timeout we have configured:

https://github.com/open-sauced/app/blob/c0a17ee26d0e7c249109d1ed60f88b38fe54a19c/playwright.config.ts#L32

A longer assertion timeout on frequently stalled tests in CI/CD help stabilize things in general.

Example timeout from CICD: https://github.com/open-sauced/app/actions/runs/10604426243/job/29391054608#step:7:400 and on the more powerful runner https://github.com/open-sauced/app/actions/runs/10623344087/job/29449581773?pr=4070

    Error: Timed out 5000ms waiting for expect(locator).toHaveAttribute(expected)

Related to #3946

github-actions[bot] commented 2 months ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

open-sauced[bot] commented 2 months ago

:tada: This issue has been resolved in version 2.63.0-beta.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: