open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
415 stars 220 forks source link

Bug: Split Button not Rendering for smaller screens #4100

Open nickytonline opened 6 days ago

nickytonline commented 6 days ago

Describe the bug

We shipped the split button to replace the Add to Workspace and Create Workspace from SBOM buttons on a repository page, but missed adding it for smaller screens.

Steps to reproduce

  1. Go to any repository page and shrink the page width until it hits the smallest breakpoint.

CleanShot 2024-09-11 at 07 52 43

github-actions[bot] commented 6 days ago

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

zeucapua commented 6 days ago

I believe this is due to the mobile view using AddToWorkspaceDrawer has it's own trigger prop that requires a button and there are no other way to trigger it. Let me look into the drawer library and see if there's a workaround to opening the drawer from somewhere other than the trigger. Initial thoughts: maybe use a ref to the button?