open-sauced / app

🍕 Insights into your entire open source ecosystem.
https://pizza.new
Apache License 2.0
429 stars 228 forks source link

feat: implement 'no interest' state to `/explore` Recommendation Section #4149

Closed zeucapua closed 1 month ago

zeucapua commented 1 month ago

Description

If a user has no interests set, they will not get recommendations. The /explore "Recommended For You" section will instead show the list of interests for the user to pick from. On update/refresh, the page should start showing recommendations.

Related Tickets & Documents

Closes #4124

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Tier (staff will fill in)

[optional] What gif best describes this PR or how it makes you feel?

larry-david-curb-your-enthusiasm-gif

netlify[bot] commented 1 month ago

Deploy Preview for oss-insights ready!

Name Link
Latest commit 1de38c71c00f100733368f386252abb90f0d599a
Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66febc5b4de777000867084a
Deploy Preview https://deploy-preview-4149--oss-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for design-insights ready!

Name Link
Latest commit 1de38c71c00f100733368f386252abb90f0d599a
Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66febc5bf9034d0008373722
Deploy Preview https://deploy-preview-4149--design-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nickytonline commented 1 month ago

I get the login screen as well, but also no workspaces are loaded or trending repos.

CleanShot 2024-10-01 at 13 14 35@2x

Discover Workspaces seems off as well. The heading is all scrunched on larger screens whereas the other headings are not when the windows is fully maximized on my 14" MBP.

CleanShot 2024-10-01 at 13 17 19

zeucapua commented 1 month ago

After I log in, I get the "Connect with GitHub" view:

Screenshot 2024-10-01 at 11 36 45 AM

and then a few seconds latter, it flips to the recommended view: can we have a loading state instead?

There should be a loading state, but it's weird it's not showing up. I assume it's cause the useSession hook takes a minute so it thinks that a user isn't logged in. Let me change things around to fix.

zeucapua commented 1 month ago

I get the login screen as well, but also no workspaces are loaded or trending repos.

CleanShot 2024-10-01 at 13 14 35@2x

Discover Workspaces seems off as well. The heading is all scrunched on larger screens whereas the other headings are not when the windows is fully maximized on my 14" MBP.

CleanShot 2024-10-01 at 13 17 19

Your comment seems to be inline with the DNS errors when migrating the beta API on the backend. Trending should be loading, and the Discover Workspaces section will error since they are hardcoded for production workspaces. There's an issue to change it based on the environment here: https://github.com/open-sauced/app/issues/4107

nickytonline commented 1 month ago

I'm still getting errors for trending repositories, and like @jpmcb, no workspaces are loading. I'm guessing workspaces aren't loading because they are production workspace IDs. We don't have an administration page for stuff like this, so consider adding FEATURED_WORKSPACES as an environment variable for now. I can show you how to set this up in Netlify so we have beta and prod worskpace IDs.

https://github.com/open-sauced/app/blob/1de38c71c00f100733368f386252abb90f0d599a/pages/explore/index.tsx#L23-L30

CleanShot 2024-10-06 at 10 45 36

Also, if I'm logged out, I get a hydration error.

CleanShot 2024-10-06 at 10 46 01

BekahHW commented 1 month ago

Can we change the copy to be more general for maintainer or contributor? Also, bc it takes the user to the repo page as well:

Current Here are some repositories we think would be great for you. Click on one to start contributing!

Suggestion

Discover repositories tailored to your interests. Click any to learn more!

Additional Change Below the "Recommended for You" heading, remove the copy (Here are some repositories we think would be great for you. Click on one to start contributing!) if there are no projects displayed.

zeucapua commented 1 month ago

Closed - not priority, will not merge anytime soon.