fix: resolve a11y warnings for label-has-associated-control rule

[shubhamchasing]

Description

Fixes warnings for rule - jsx-a11y/label-has-associated-control

Related Tickets & Documents

Fixes #4126

Mobile & Desktop Screenshots/Recordings

Before

After

Steps to QA

1 run npm run lint in the root folder and see warnings are not occurring.

Tier (staff will fill in)

• [ ] Tier 1
• [ ] Tier 2
• [ ] Tier 3
• [ ] Tier 4

[optional] What gif best describes this PR or how it makes you feel?

[netlify[bot]]

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	c511e7f9bf03ee3315dcb64eaa2ece2da20e22bb
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/6723e299acdf0100085ae8cb
😎 Deploy Preview	https://deploy-preview-4152--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify[bot]]

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	c511e7f9bf03ee3315dcb64eaa2ece2da20e22bb
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/6723e29927008d00088b5c83
😎 Deploy Preview	https://deploy-preview-4152--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nickytonline]

Hi @shubhamchasing, just seeing if you're blocked on anything. No rush on this, just checking in.

[shubhamchasing]

My apologies @nickytonline I will submit the changes before this weekend, thanks for offering help

[nickytonline]

My apologies @nickytonline I will submit the changes before this weekend, thanks for offering help

No need to apologize. 😎 I was just checking in.

[shubhamchasing]

@nickytonline It seems I made some mistake I merged the latest changes to my fix branch and resolved the conflicts but components/organisms/UserSettingsPage/developer-pack-form.tsx empty file is still there, can I delete the empty file in this PR or what can be other solution?

[nickytonline]

components/organisms/UserSettingsPage/developer-pack-form.tsx no longer exists so if you merge latest into your branch, it should remove it. If you run into issues, delete the file in your PR.

[shubhamchasing]

components/organisms/InsightPage/InsightPage.tsx I think this file is also not used anywhere, can you please confirm?

Edit: I think the below files are unused too or I am making a mistake to find them, please confirm

• components/molecules/FilterCardSelect/filter-card-select.tsx used in components/molecules/FilterHeader/filter-header.tsx it is unused

• components/molecules/SelectReportsFilter/select-reports-filter.tsx used in components/organisms/Reports/reports.tsx but it is unused and its related files

• components/molecules/TeamMemberRow/team-member-row.tsx used in components/molecules/TeamMembersConfig/team-members-config.tsx it is unused

please let me know what files to remove so I do not remove any file which is used somewhere

[nickytonline]

components/organisms/InsightPage/InsightPage.tsx I think this file is also not used anywhere, can you please confirm?

@shubhamchasing, yes, the components/organisms/InsightPage/InsightPage.tsx can be removed as well.

[shubhamchasing]

please check the edited comment https://github.com/open-sauced/app/pull/4152#issuecomment-2439758417

[shubhamchasing]

components/organisms/InsightPage/InsightPage.tsx I think this file is also not used anywhere, can you please confirm?

Edit: I think the below files are unused too or I am making a mistake to find them, please confirm

• components/molecules/FilterCardSelect/filter-card-select.tsx used in components/molecules/FilterHeader/filter-header.tsx it is unused
• components/molecules/SelectReportsFilter/select-reports-filter.tsx used in components/organisms/Reports/reports.tsx but it is unused and its related files
• components/molecules/TeamMemberRow/team-member-row.tsx used in components/molecules/TeamMembersConfig/team-members-config.tsx it is unused

please let me know what files to remove so I do not remove any file which is used somewhere

@nickytonline I understand you must be busy but I wanted to close this PR as I took more time on this PR than I should have

[brandonroberts]

Apologies @shubhamchasing. Did you mean close as in complete, or no longer work on?

[shubhamchasing]

I will complete, just waiting for Nick's input

[shubhamchasing]

Thanks @nickytonline, I learned something new 🚀