Open Bashamega opened 1 month ago
Visit the deploys page to approve it
Name | Link |
---|---|
Latest commit | 201cd63d542d2122e1dd2ffb54cdcc44910e524f |
Name | Link |
---|---|
Latest commit | 201cd63d542d2122e1dd2ffb54cdcc44910e524f |
Latest deploy log | https://app.netlify.com/sites/design-insights/deploys/671bb0be3905640008787cfd |
Deploy Preview | https://deploy-preview-4159--design-insights.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hi @Bashamega, just seeing if you're blocked on anything. No rush on this, just checking in.
Hi @Bashamega, just seeing if you're blocked on anything. No rush on this, just checking in.
I don't quite understand the required changes
I'm just looking at the PR again, and it looks like the additional feedback I made wasn't saved. I'll post it shortly.
Description
The changes include adding
tabIndex={0}
to elements withrole="tab"
to ensure they are focusable for keyboard navigation, addressing the accessibility warning (jsx-a11y/interactive-supports-focus). Additionally, anonKeyDown
handler was introduced to allow keyboard interaction, enabling users to select tabs using the Enter or Space keys. These changes improve both accessibility and user experience by making the tabs keyboard-accessible.Related Tickets & Documents
fixes #4138
Mobile & Desktop Screenshots/Recordings
lint output:
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?