[CI] Create a Storybook deploy for each PR that has "storybook" checked

open-sauced / app

🍕 Insights into your entire open source ecosystem.

https://pizza.new

Apache License 2.0

426 stars 225 forks source link

[CI] Create a Storybook deploy for each PR that has "storybook" checked #49

Closed eryc-cc closed 2 years ago

eryc-cc commented 2 years ago

Following up on our conversation today:

What we can do is have a workflow/action that triggers the npm run storybook for that Netlify everytime that a person makes a change in a component and checks "Storybook" from the PR description:

That way, we'd have both the Netlify link for the Portal, and for the Design System, and we don't have to manually push our WIP or blocked PRs to the main build of the design system.

I'll open an issue on this.

Originally posted by @pixelsbyeryc in https://github.com/open-sauced/insights/issues/38#issuecomment-1180869005

bdougie commented 2 years ago

Leaving a note for myself when I take this on. Not if the below will work, but this is my initial thought on the approach.

I think we can just search if the string -[x]📕 storybook exists as-is. Based on that we can deploy manually using a build to a new branch that follows this pattern ${GITHUB_BRANCH}-storybook

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.0.4-beta.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.0.4-alpha.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

eryc-cc commented 2 years ago

@0-vortex Has this been resolved by your latest PR? It still shows as open to me

0-vortex commented 2 years ago

@0-vortex Has this been resolved by your latest PR?

Yes but I am doing some UAT testing on alpha->beta->production now, to get all them fancy URLs going and stuff like:

Alpha is getting CDN cached as we speak 🍕

0-vortex commented 2 years ago

@pixelsbyeryc It's gonna auto-close when the commit gets to main, just wait and see!

eryc-cc commented 2 years ago

@pixelsbyeryc It's gonna auto-close when the commit gets to main, just wait and see!

Saucy AF 🍕🍕

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.1.0-beta.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: