open-sauced / hot

πŸ•The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
426 stars 149 forks source link

Feature: New PostList cards #203

Closed bdougie closed 2 years ago

bdougie commented 2 years ago

Type of feature

πŸ• Feature

Current behavior

We are combing the list and grid views. Currently we have a list card view that lacks information and hides the vote button amongst data. We need to update this.

Suggested solution

  1. Remove the list/grid toggle and place it with a list view only.
  2. This change will support #202. The hot card section will be placed above the list view.
Screen Shot 2022-07-15 at 6 37 09 AM

Link to figma

Additional context

password to figma is secretsauce

Code of Conduct

Contributing Docs

eryc-cc commented 2 years ago

When you click to "upvote":

Screen Shot 2022-07-16 at 12 02 20 AM
shamimbinnur commented 2 years ago

@bdougie @pixelsbyeryc how many cards will be shown here as initially? Don't we need a button to load more cards? We will be fetching cards and showing up right in this section? Or will we send users to different routes/pages to show all the cards in there?

eryc-cc commented 2 years ago

@shamimbinnur In the conversations I had with @bdougie, we were going to work similarly to ProductHunt, it might make sense to keep fetching the cards as the user scrolls.

So we have 2 options:

  1. They can search for a specific repo
  2. They can browse the timeline of repos

Now, we have other questions:

0-vortex commented 2 years ago

We have the backend capable of producing pagination in the form of:

{
  "meta": {
    "page": 1,
    "take": 10,
    "itemCount": 6856,
    "pageCount": 686,
    "hasPreviousPage": false,
    "hasNextPage": true
  }
}

IMHO the most user friendly mechanism I envision is to create a top-fixed or bottom-padded client pagination, then add a function to click the next/prev page on scroll and advance the page without any invisible elements or the user being unable to quickly access filters.

Why not best of both worlds? πŸ•

shamimbinnur commented 2 years ago

I can think infinite scrolling can be a barrier to reaching out to the next component below the "Post List" component. We may have to add more components(ex. footer) below that in the future.

0-vortex commented 2 years ago

I can think infinite scrolling can be a barrier to reaching out to the next component below the "Post List" component. We may have to add more components(ex. footer) below that in the future.

We can work around that by using a holy grail kind of layout and only scrolling the middle section. The more modern approach to that is https://layout.bradwoods.io but I am also happy to suggest old-school IE6 positioning techniques.

The pagination would act the same way, padding fixed spaced on top of the already padded body/footer space πŸ•

shamimbinnur commented 2 years ago

242

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.16.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: