Search will have command+K option to show search.

[bdougie]

This work should be done in a separate PR from #200. We will need to implement using command + K or Ctrl + K to open the search box. I am sure there is a plugin for keyboard commands, but have not done the research.

This work cannot merge without #200

[ddsuhaimi]

Just wanna recommend a package, I use react-hot-keys in one of my projects and it works well so far.

[ddsuhaimi]

@bdougie I can work on this one, but what do you mean by opening the search box? the input should just be focused when user press CTRL + K right?

[0-vortex]

@bdougie I can work on this one, but what do you mean by opening the search box? the input should just be focused when user press CTRL + K right?

We have the rooks package installed, this ticket should be an implementation of https://react-hooks.org/docs/useKeyBindings linking the cmd/ctrl+k shortcut to the existing event handler on the search box 🍕

[ddsuhaimi]

@0-vortex I see, just to confirm. If user press cmd/ctrl+k then the search box will open up like this, right? So user can type immediately.

[shamimbinnur]

@ddsuhaimi this issue is already assigned to me :)

[0-vortex]

@ddsuhaimi this issue is already assigned to me :)

I don't see a problem with 2 people working on the same issue, as long as they coordinate accordingly. I see you have an open PR @shamimbinnur, do you have any work done on this issue?

If not, it would be best to let someone else do it if they are willing to, in order to discourage a "dibs" like scenario. We want to prevent scope creeping and as such, we generally assign 1 issue at a time unless the complexity demands a specific maintainer/contributor.

Let me know if there are other ways I can help!

[shamimbinnur]

@ddsuhaimi this issue is already assigned to me :)

I don't see a problem with 2 people working on the same issue, as long as they coordinate accordingly. I see you have an open PR @shamimbinnur, do you have any work done on this issue?

If not, it would be best to let someone else do it if they are willing to, in order to discourage a "dibs" like scenario. We want to prevent scope creeping and as such, we generally assign 1 issue at a time unless the complexity demands a specific maintainer/contributor.

Let me know if there are other ways I can help!

@0-vortex I was working on this issue while I was working on the hero. But as this issue was asked to solve on separate PR. I stopped there and waited to be merged. No problem if @ddsuhaimi takes this over now.

[ddsuhaimi]

@shamimbinnur oops sorry, didn't realize it was taken already

okay, I will work on this

[github-actions[bot]]

:tada: This issue has been resolved in version 2.17.0 :tada:

The release is available on:

• GitHub release
• ghcr.io container (@latest dist-tag)

Your semantic-release bot :package::rocket: