search

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
426 stars 148 forks source link

fix: Submit button z-index is below the hot repos #248

Closed Ryankolsen closed 2 years ago

Ryankolsen commented 2 years ago

Definitely my first pull request. I apologize if I did not use the right form, I'm trying!

**Also, I definitely only changed line 73, please point me in the right direction if I screwed this up somehow: I literally just added: z-[1]

What type of PR is this? (check all applicable)

Description

This PR fixes the RepoSubmission.tsx component to be positioned above/in front of the hot repos. I changed the Z index rather than messing with a whole lot of CSS. (I thought it was best to keep my first attempt simple)

Related Tickets & Documents

Closes #237

Mobile & Desktop Screenshots/Recordings

Blocked Image: SuggRepoImgBlocked

Corrected Z Index SuggRepoImgShownrev

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

Nope, unless someone wants to use a different method other than z-index to resolve this. I also wanted to add a black border to show a bit more contrast...but I really don't want to start making unauthorized changes to a project that I'm just starting to get involved with.

[optional] What gif best describes this PR or how it makes you feel?

whoop-the-office

netlify[bot] commented 2 years ago

Deploy Preview for hot-sauced-ui ready!

Name Link
Latest commit 64d71c91c45e70df63326c77f461008211603187
Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/62e16ea642c661000918df6c
Deploy Preview https://deploy-preview-248--hot-sauced-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

0-vortex commented 2 years ago

Changed z-[1] to z-10 to avoid having an on the fly generated CSS class, it should be good to go after this! 🍕

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.12.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Ryankolsen commented 2 years ago

Thank you!! sorry, this was my first time using Tailwind and I appreciate all the help!

...also, should I delete this branch now?

0-vortex commented 2 years ago

Thank you!! sorry, this was my first time using Tailwind and I appreciate all the help!

...also, should I delete this branch now?

No worries, the deploy preview was broken and reading on z-index while reviewing made me realize it's a minor improvement, not really worth a review or change request - as a maintainer I could just add that along with the merge! 🍕

You can delete the branch of course, but this is all happening inside your fork so not needed. When you sync your fork with upstream your branches will remain, if you are not bothered by them while writing code I suggest keeping them around - they act like fixed snapshots in time of the code you write, sometimes it makes sense when you are writing a blog post to, for example, link a PR or a branch you are running in the fork for people to have additional context on your post! 🍕

Ryankolsen commented 2 years ago

This all makes sense now - thank you again for all the help. I used a ton of Git, but it is very different when you're working with others. I'm excited to contribute in a more meaningful way, but right now I'll fix whatever I can :)

0-vortex commented 2 years ago

This all makes sense now - thank you again for all the help. I used a ton of Git, but it is very different when you're working with others. I'm excited to contribute in a more meaningful way, but right now I'll fix whatever I can :)

Thank you, every contribution is meaningful! Glad you are enjoying open source 🍕