search

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
426 stars 148 forks source link

fix: popular text is now aligned #254

Closed burneikis closed 2 years ago

burneikis commented 2 years ago

253 fixed, refer to my comment on the issue for how this works :)

netlify[bot] commented 2 years ago

Deploy Preview for hot-sauced-ui ready!

Name Link
Latest commit 48a1c60f7cb10e8afbe0d2eb0e41cca88ad45082
Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/62e217843752c300084a4d7b
Deploy Preview https://deploy-preview-254--hot-sauced-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bdougie commented 2 years ago

Welcome to the party. We did get a contribution for this already on #253. That pr and this one both leave out consideration for mobile

image

burneikis commented 2 years ago

Aha, my bad, I'll have a quick looksie

burneikis commented 2 years ago

Should work now, I've changed it back to use space-y-2 and sm:space-y-0 so that it works for mobile and doesn't apply it on desktop

bdougie commented 2 years ago

Thanks for the work on this, however I went with #253. That result visually is the same and that contributor followed the contributing guidelines. Feel free to take another issue.

Again appreciate the work, but do consider assigning yourself to the issue before beginning work in the future.