search

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
426 stars 148 forks source link

Bug: dedupe handleVoteUpdateByRepo function #271

Closed 0-vortex closed 2 years ago

0-vortex commented 2 years ago

Describe the bug

Any part of the website that can be used to vote requires posthog and as such the handleVoteUpdateByRepo function should be deduplicated and moved to the lib folder.

Steps to reproduce

Duplicated code exists in:

Affected services

hot.opensauced.pizza

Platforms

No response

Browsers

No response

Environment

No response

Additional context

No response

Code of Conduct

Contributing Docs

OgDev-01 commented 2 years ago

.take

github-actions[bot] commented 2 years ago

Thanks for taking this on! If you have not already, join the conversation in our Discord

OgDev-01 commented 2 years ago

having errors related to line breaks after pulling updates from the main repo... Screenshot (17)

Can any one propose a fix to this? would appreciate

0-vortex commented 2 years ago

having errors related to line breaks after pulling updates from the main repo...

Screenshot (17)

Can any one propose a fix to this? would appreciate

npm run format should fix the issur - it's complaining about line endings (which are windows atm). When commiting, git sets them to LF (unix).

This should be a better way to fix it: https://stackoverflow.com/questions/2517190/how-do-i-force-git-to-use-lf-instead-of-crlf-under-windows

OgDev-01 commented 2 years ago

having errors related to line breaks after pulling updates from the main repo... Screenshot (17) Can any one propose a fix to this? would appreciate

npm run format should fix the issur - it's complaining about line endings (which are windows atm). When commiting, git sets them to LF (unix).

This should be a better way to fix it: https://stackoverflow.com/questions/2517190/how-do-i-force-git-to-use-lf-instead-of-crlf-under-windows

Thanks @0-vortex, you the boss :)

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.21.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: