search

open-sauced / hot

🍕The site that recommends the hottest projects on GitHub.
https://hot.opensauced.pizza
MIT License
426 stars 148 forks source link

fix: dedupe handleVoteUpdateByRepo function #292

Closed OgDev-01 closed 2 years ago

OgDev-01 commented 2 years ago

What type of PR is this? (check all applicable)

Description

This PR replaces duplicate codes with a single reusable one.

Related Tickets & Documents

fixes #271

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 2 years ago

Deploy Preview for hot-sauced-ui ready!

Name Link
Latest commit f6845b8aceb31fe26ca6ffe43b9f7dc56eeac70b
Latest deploy log https://app.netlify.com/sites/hot-sauced-ui/deploys/62ec30ea5a63db00082ce1bd
Deploy Preview https://deploy-preview-292--hot-sauced-ui.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

OgDev-01 commented 2 years ago

LGTM! Regarding the eslint formatting, was this done by the IDE automatically? (like vsc eslint/prettier autoconf)

I will add this file to the eslint ignore array in a future update just to be sure.

Will test the unknown consequence and merge this afterwards (might take a day tho)

Thank you for another great contribution, feel free to grab another one if you feel like it! 🙇 🍕 🚀

it was auto formatted by my IDE automatically... thanks for the review. i'm still new to typescript though :).

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.21.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: