refactor: add submit a repo to the nav

takanome-dev commented 2 years ago

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑‍💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Description

I removed the submit repo? button and I added it to the navigation. If the user is not logged in, he will add a username and repo url.

not-auth not-auth-dropdown

Otherwise, he will only add the repo url

auth-dropdown submit

Related Tickets & Documents

Fixes #301

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify[bot] commented 2 years ago

Deploy Preview for hot-sauced-ui ready!

Name	Link
Latest commit	c4ca53783358a4446c59a6abf57b07ff243ca17c
Latest deploy log	https://app.netlify.com/sites/hot-sauced-ui/deploys/6305611616da2b00082c1572
Deploy Preview	https://deploy-preview-310--hot-sauced-ui.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bdougie commented 2 years ago

Took a look at the preview. A few things.

The link in the nav was meant to be logged in only, but I see it in the dropdown. TBH it actually works better for me there. If you remove link in the nav, we can merge this.

Screen Shot 2022-08-16 at 3 15 55 PM

A few problems with that form as well. We can infer the user if they are logged in and will introduce a honeypot for spammers Screen Shot 2022-08-16 at 3 15 59 PM

I really like having this added to the dropdown.

Screen Shot 2022-08-16 at 3 17 36 PM

bdougie commented 2 years ago

@open-sauced/triage take a look

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.24.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

open-sauced / hot